Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullscreen and icewm #613

Closed
zaza42 opened this issue Mar 30, 2019 · 4 comments
Closed

fullscreen and icewm #613

zaza42 opened this issue Mar 30, 2019 · 4 comments
Labels
Milestone

Comments

@zaza42
Copy link

zaza42 commented Mar 30, 2019

  • Version: 1.4.0
  • Install type: manually created package with -Os and -flto flags
  • Distro and version: Debian sid+experimental
  • Window manager: IceWM 1.5.3

The new fullscreen feature acts weird to me, especially pushback. When I do fullscreen in urxvt (f11), the first time the notification gets disappeared, but when switch back from fullscreen, nothing shown. Dunst is only triggered, when i activate another window; then the notification reappears.
The second try with another notification message and fullscreened urxvt doesn't hide the notification window at all.

I think this bug can be easily reproduced with icewm + urxvt.

Bonus: the delayed (pushbacked) notification can't be closed with ctrl+space until i activate another window.

The lines I used in dunstrc:

[fullscreen_delay_everything]
    fullscreen = pushback
[fullscreen_show_critical]
    msg_urgency = critical
    fullscreen = pushback

And I've also tried fullscreen = pushback in [global] section.

@tsipinakis
Copy link
Member

That's weird, it works perfectly on i3, iceWM must be doing something different with the fullscreen hints/events.

I'll setup iceWM in a VM later today to try and reproduce this.

@tsipinakis tsipinakis added this to the 1.4.1 milestone Apr 8, 2019
@tsipinakis
Copy link
Member

I apologize for the unreasonably huge delay on this issue, finally got some time to figure this one out.

The problem is the following:
We check whether there is a fullscreen window available every time one of the following events is sent: FocusIn, FocusOut, PropertyNotify.
In my WM (i3) I observe that the following events are sent:

(window enters fullscreen)
...
PropertyNotify: _NET_CLIENT_LIST_STACKING
PropertyNotify: _NET_CLIENT_LIST
...

(window exits fullscreen)
...
PropertyNotify: _NET_CLIENT_LIST_STACKING
PropertyNotify: _NET_CLIENT_LIST
...

However, with IceWM the above events are only sent when fullscreen is entered but not when it exits. It works correctly when you switch focus to another window as we are also monitoring the Focus{In,Out} events for redundancy, so that partly saved us here.

What's still not clear to me is whether this is a bug in IceWM or if it's by design and we are updating on the wrong hints.

@tsipinakis
Copy link
Member

I've opened an issue on IceWm's repo as well, monitor bbidulock/icewm#347.

@tsipinakis
Copy link
Member

I've put together a band-aid solution by forcing dunst to update the fullscreen status on ConfigureNotify events. It seems to work just fine in this case and hopefully all others.

This is not a proper fix however. I've opened #637 to try and work out a better one at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants