how are metrics being counted ?

[IndraGunawan]

hi,
i have some questions related to metrics, i wanted to know if those are expected or not

1. in non-worker mode, is it expected that the value of frankenphp_busy_threads can exceed the value of frankenphp_total_threads ?
   

2. in worker mode with default config. frankenphp_total_threads value will be 2x available CPUs + 1 and frankenphp_busy_threads will be constantly total threads of workers (frankenphp.worker.num config)
   from my observation. if FrankenPHP has multiple worker the default value of frankenphp_total_threads = 2x available CPUs X number worker + 1

3. in worker mode i do set. frankenphp.worker.num = 5 but frankenphp_*_busy_workers can exceed that value (same as question no 1)

4. frankenphp_*_ready_workers values can go down below 0 but still can serve request
   

i did test FrankenPHP from main branch (4c92633) by using this Caddyfile and this index.php with a modification by adding sleep(31) under echo statement.

[withinboredom]

is it expected that the value of frankenphp_busy_threads can exceed the value of frankenphp_total_threads

Yes. If busy threads goes above total threads, the difference is the number of requests "queued" and waiting for a thread. This is documented in an issue but needs to be documented in the docs as well, now that you mention it. The same thing happens for workers.

frankenphp_*_ready_workers values can go down below 0 but still can serve request

This is due to the current worker implementation -- and somewhat annoying. I'm waiting on #1266 to be merged before addressing it (if it isn't incidentally fixed along the way) to avoid how this bug got here in the first place: merge conflicts.

[IndraGunawan]

@withinboredom i have tried with the latest release (v1.4.4) but the issue still persists.

i'm not sure if this related to this #1371 as i put sleep(31) on the controller while testing