Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a phpcs.xml file #227

Open
dawehner opened this issue Dec 8, 2016 · 2 comments
Open

Adding a phpcs.xml file #227

dawehner opened this issue Dec 8, 2016 · 2 comments
Labels
State: Needs more discussion The issue requires more discussion Type: Feature Issue is a new feature request

Comments

@dawehner
Copy link

dawehner commented Dec 8, 2016

It would be kind of nice to ship with a phpcs.xml file. Ideally this would be default at least have the rules be available in core by default, and point to just code running in modules/custom, themes/custom

@gergelypap
Copy link

gergelypap commented May 11, 2017

+1

We can use core's ruleset as a starting point: https://github.com/drupal/drupal/blob/8.4.x/core/phpcs.xml.dist

@AlexSkrypnyk AlexSkrypnyk changed the title Adding a phpcs.xmlfile Adding a phpcs.xml file May 12, 2024
@AlexSkrypnyk
Copy link
Collaborator

Since this projects provides tooling via drupal/core-dev, supporting of the configs for that tooling does make sense.

If we decide to do so, we would need to:

  1. Add PHPCS configuration to support Coder rules with custom locations as targets.
  2. Update CI config to include code standards check using PHPCS

@AlexSkrypnyk AlexSkrypnyk self-assigned this May 12, 2024
@AlexSkrypnyk AlexSkrypnyk added Type: Feature Issue is a new feature request State: Needs more discussion The issue requires more discussion and removed feature request labels May 13, 2024
@AlexSkrypnyk AlexSkrypnyk removed their assignment May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs more discussion The issue requires more discussion Type: Feature Issue is a new feature request
Projects
None yet
Development

No branches or pull requests

4 participants