-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a custom exception list and add to tests #1
Comments
It looks like currently only Postgres driver exception is not handled by the deferred object. Here instead of I'll try to fix Postgres driver and add a test for exception handling. |
@seregazhuk a DBAL should always work with custom exceptions, instead of working with specific ones. That means that if mysql adapter throws an exception for Timeout, we should catch it and make a conversion per each adapter. AT the end, we should be able to work 100% with custom DBAL namespaces in our code, being able to switch between adapters :) Could we make that list here? |
@seregazhuk started here - #3 |
@mmoreram Aren't you reinventing the wheel here? Doctrine DBAL already has this logic for mapping driver error cases into exceptions. For example, your case with I think that we should somehow reuse doctrine logic, instead of rewriting everything from scratch. |
@seregazhuk LOL. Good to hear that. |
Closing because already implemented in Doctrine. |
Yes! |
No description provided.
The text was updated successfully, but these errors were encountered: