Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres support #4

Open
matijakovacevic opened this issue Feb 22, 2019 · 3 comments
Open

Add postgres support #4

matijakovacevic opened this issue Feb 22, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@matijakovacevic
Copy link

is it planned?

@drfraker
Copy link
Owner

drfraker commented Feb 22, 2019

No, I haven't planned it, yet... Do you want to submit a PR to add support for it? I want to add support for sqlite and in-memory sqlite. To do this I'm thinking about splitting out some code and using database drivers to handle the snapshot creation and import stuff. Once that's done adding postgress should be much easier.

@drfraker drfraker added the enhancement New feature or request label Feb 22, 2019
@drfraker drfraker changed the title postgres support Add postgres support Feb 22, 2019
@matijakovacevic
Copy link
Author

To do this I'm thinking about splitting out some code and using database drivers to handle the snapshot creation and import stuff

Good point and I totally agree.
I could make a PR for Postgres.
Tag me in this issue once you've completed code rewrite using db drivers. Until then I will try to go through the code to see the details of the package.

P.S.
As the package is specific to Laravel and still fresh, a proposition about package naming convention.

Something along the line *drfraker/laravel-*nameofpackage,
to imply an extension upon the framework and not a general package.

@drfraker
Copy link
Owner

Does the latest pull request help solve this issue?
PR 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants