Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune eviction threshold in cache mode #4011

Open
adiholden opened this issue Oct 29, 2024 · 3 comments · May be fixed by #4772
Open

Tune eviction threshold in cache mode #4011

adiholden opened this issue Oct 29, 2024 · 3 comments · May be fixed by #4772
Assignees
@BagritsevichStepan
Labels
bug Something isn't working

Comments

@adiholden
Copy link
Collaborator

Today eviction starts on 90% memory usage in cache mode
If we set deny_oom_flag to lower than 90% then we reject writes and no eviction is taking place.
We need to set the threshold so it will take into account this flag
@adiholden adiholden added the bug Something isn't working label Oct 29, 2024
@adiholden adiholden added the Next Up task that is ready to be worked on and should be added to working queue label Oct 29, 2024
@adiholden
Copy link
Collaborator Author

adiholden commented Nov 5, 2024 •
edited
Loading

flag names : rss_oom_deny_ratio oom_deny_ratio
pytest for reference how to check eviction : test_heartbeat_eviction_propagation

BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 18, 2024
@BagritsevichStepan
cache(cache_mode): Tune eviction threshold in cache mode
cdd7fc0 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
@BagritsevichStepan BagritsevichStepan mentioned this issue Nov 18, 2024
Merged
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 18, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
b5e1611 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Nov 18, 2024
@BagritsevichStepan
fix(eviction): Tune eviction threshold in cache mode
1d7035c 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
@BagritsevichStepan
Copy link
Contributor

BagritsevichStepan commented Nov 21, 2024 •
edited
Loading

Another issue (#4139) was created for this task

@BagritsevichStepan BagritsevichStepan removed the Next Up task that is ready to be worked on and should be added to working queue label Mar 12, 2025
BagritsevichStepan added a commit to BagritsevichStepan/dragonfly that referenced this issue Mar 15, 2025
@BagritsevichStepan
feat(eviction): Add eviction based on RSS memory
3f70d04 
fixes dragonflydb#4011

Signed-off-by: Stepan Bagritsevich <[email protected]>
@BagritsevichStepan BagritsevichStepan linked a pull request Mar 15, 2025 that will close this issue
Draft
@BagritsevichStepan
Copy link
Contributor

Current problem: mimalloc does not release RSS memory back to the OS. Alternatively, the OS might not be reclaiming this freed memory due to a lack of memory pressure. This is a common issue in mimalloc, and I have tried various options, but only one of them helped.

The more info is provided in this PR: #4772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BagritsevichStepan BagritsevichStepan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eviction): Add eviction based on RSS memory. DRAFT BagritsevichStepan/dragonfly
2 participants
@BagritsevichStepan @adiholden