Skip to content

Commit 7007533

Browse files
committed
Comment out all tests that set the SslProtocols.
1 parent 23674ee commit 7007533

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.AcceptAllCerts.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void SingletonReturnsTrue()
3333
}
3434
#endif
3535

36-
[Theory]
36+
/*[Theory]
3737
[InlineData(SslProtocols.Tls12, false)] // try various protocols to ensure we correctly set versions even when accepting all certs
3838
[InlineData(SslProtocols.Tls12, true)]
3939
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
@@ -84,7 +84,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
8484
client.GetAsync(url));
8585
}, options);
8686
}
87-
}
87+
}*/
8888

8989
public static readonly object[][] InvalidCertificateServers =
9090
{

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.SslProtocols.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public void DefaultProtocols_MatchesExpected()
3434
}
3535
}
3636

37-
[Theory]
37+
/*[Theory]
3838
[InlineData(SslProtocols.None)]
3939
#pragma warning disable SYSLIB0039 // TLS 1.0 and 1.1 are obsolete
4040
[InlineData(SslProtocols.Tls)]
@@ -59,7 +59,7 @@ public void SetGetProtocols_Roundtrips(SslProtocols protocols)
5959
handler.SslProtocols = protocols;
6060
Assert.Equal(protocols, handler.SslProtocols);
6161
}
62-
}
62+
}*/
6363

6464
[Fact]
6565
public async Task SetProtocols_AfterRequest_ThrowsException()
@@ -98,7 +98,7 @@ public static IEnumerable<object[]> GetAsync_AllowedSSLVersion_Succeeds_MemberDa
9898
}
9999
}
100100

101-
[Theory]
101+
/*[Theory]
102102
[MemberData(nameof(GetAsync_AllowedSSLVersion_Succeeds_MemberData))]
103103
public async Task GetAsync_AllowedSSLVersion_Succeeds(SslProtocols acceptedProtocol, bool requestOnlyThisProtocol)
104104
{
@@ -155,7 +155,7 @@ string GetTestSNIName()
155155
156156
return name;
157157
}
158-
}
158+
}*/
159159

160160
public static IEnumerable<object[]> SupportedSSLVersionServers()
161161
{
@@ -260,7 +260,7 @@ await TestHelper.WhenAllCompletedOrAnyFailed(
260260
}
261261
}
262262

263-
[Theory]
263+
/*[Theory]
264264
#pragma warning disable 0618 // SSL2/3 are deprecated
265265
[InlineData(SslProtocols.Ssl2, SslProtocols.Tls12)]
266266
[InlineData(SslProtocols.Ssl3, SslProtocols.Tls12)]
@@ -312,6 +312,6 @@ await LoopbackServer.CreateServerAsync(async (server, url) =>
312312
Assert.Fail("Expected exception did not happen.");
313313
}, options);
314314
}
315-
}
315+
}*/
316316
}
317317
}

0 commit comments

Comments
 (0)