Code can be optimized?

[andrew-kuzovov]

I was looking into the Orleans code and it seems to me that this condition is always true:
if (workItemGroup?.TaskScheduler is TaskScheduler scheduler) - link
ActivationTaskScheduler TaskScheduler property is actually not nullable and always initialized to ActivationTaskScheduler instance, right?
the same redundant checks also can be found in other places

[ReubenBond]

Thanks for the input, Andrew. The value might be null, but the code could be changed to var scheduler = workItemGroup?.TaskScheduler; with a conditional guard of scheduler is not null to avoid performing the type check. The workItemGroup?.TaskScheduler is {} scheduler syntax shortens that further. Would you be open to submitting a PR?

[ReubenBond]

GetWorkItemGroup can return null

[ReubenBond]

We should enable start enabling nullability checks.

[andrew-kuzovov]

ahh ok, thx

[andrew-kuzovov]

@ReubenBond do I need some permissions to submit a PR?

[ReubenBond]

No, no permission is needed to open a PR. If it's a big PR, then it is often a good idea to submit a draft PR or a discussion issue first so that we can try to decide if we can accept it before too much effort is put into it.