Do not set cached hash code from GetConsistentHashCode(int) (#9349)

ReubenBond · web-flow · commit 6905fa9b3094 · 2025-02-13T15:35:21.000Z
diff --git a/src/Orleans.Core.Abstractions/IDs/SiloAddress.cs b/src/Orleans.Core.Abstractions/IDs/SiloAddress.cs
@@ -280,9 +280,7 @@ internal int GetConsistentHashCode(int seed)
             BinaryPrimitives.WriteInt32LittleEndian(buf[20..], Generation);
             BinaryPrimitives.WriteInt32LittleEndian(buf[24..], seed);
 
-            hashCode = (int)StableHash.ComputeHash(buf);
-            hashCodeSet = true;
-            return hashCode;
+            return (int)StableHash.ComputeHash(buf);
         }
 
         private int CalculateConsistentHashCode()

Original file line number	Diff line number	Diff line change
`@@ -280,9 +280,7 @@ internal int GetConsistentHashCode(int seed)`
`280`	`280`	`BinaryPrimitives.WriteInt32LittleEndian(buf[20..], Generation);`
`281`	`281`	`BinaryPrimitives.WriteInt32LittleEndian(buf[24..], seed);`
`282`	`282`
`283`		`- hashCode = (int)StableHash.ComputeHash(buf);`
`284`		`- hashCodeSet = true;`
`285`		`- return hashCode;`
	`283`	`+ return (int)StableHash.ComputeHash(buf);`
`286`	`284`	`}`
`287`	`285`
`288`	`286`	`private int CalculateConsistentHashCode()`