#nullable enable for new files

Author: rkargMsft

src/Orleans.Core.Abstractions/Placement/PlacementFilterAttribute.cs

@@ -3,6 +3,7 @@
 using Orleans.Metadata;
 using Orleans.Runtime;
 
+#nullable enable
 namespace Orleans.Placement;
 
 /// <summary>

src/Orleans.Core.Abstractions/Placement/PlacementFilterStrategy.cs

@@ -3,6 +3,7 @@
 using Orleans.Metadata;
 using Orleans.Runtime;
 
+#nullable enable
 namespace Orleans.Placement;
 
 public abstract class PlacementFilterStrategy
@@ -65,7 +66,7 @@ public void PopulateGrainProperties(IServiceProvider services, Type grainClass,
         }
     }
 
-    protected string GetPlacementFilterGrainProperty(string key, GrainProperties properties)
+    protected string? GetPlacementFilterGrainProperty(string key, GrainProperties properties)
     {
         var typeName = GetType().Name;
         return properties.Properties.TryGetValue($"{WellKnownGrainTypeProperties.PlacementFilter}.{typeName}.{key}", out var value) ? value : null;

src/Orleans.Core/Placement/IPlacementFilterDirector.cs

@@ -2,6 +2,7 @@
 using Orleans.Runtime;
 using Orleans.Runtime.Placement;
 
+#nullable enable
 namespace Orleans.Placement;
 
 public interface IPlacementFilterDirector

src/Orleans.Core/Placement/PlacementFilterExtensions.cs

@@ -1,5 +1,6 @@
 using Microsoft.Extensions.DependencyInjection;
 
+#nullable enable
 namespace Orleans.Placement;
 
 public static class PlacementFilterExtensions

src/Orleans.Runtime/MembershipService/SiloMetadata/ISiloMetadataCache.cs

@@ -1,5 +1,6 @@
-namespace Orleans.Runtime.MembershipService.SiloMetadata;
 #nullable enable
+namespace Orleans.Runtime.MembershipService.SiloMetadata;
+
 public interface ISiloMetadataCache
 {
     SiloMetadata GetMetadata(SiloAddress siloAddress);

src/Orleans.Runtime/MembershipService/SiloMetadata/ISiloMetadataClient.cs

@@ -1,6 +1,7 @@
 using System.Threading.Tasks;
 using Orleans.Services;
 
+#nullable enable
 namespace Orleans.Runtime.MembershipService.SiloMetadata;
 
 public interface ISiloMetadataClient : IGrainServiceClient<ISiloMetadataGrainService>

src/Orleans.Runtime/MembershipService/SiloMetadata/ISiloMetadataGrainService.cs

@@ -1,6 +1,7 @@
 using System.Threading.Tasks;
 using Orleans.Services;
 
+#nullable enable
 namespace Orleans.Runtime.MembershipService.SiloMetadata;
 
 [Alias("Orleans.Runtime.MembershipService.SiloMetadata.ISiloMetadataGrainService")]

src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadaCache.cs

@@ -8,8 +8,9 @@
 using Orleans.Configuration;
 using Orleans.Internal;
 
-namespace Orleans.Runtime.MembershipService.SiloMetadata;
 #nullable enable
+namespace Orleans.Runtime.MembershipService.SiloMetadata;
+
 internal class SiloMetadataCache(
     ISiloMetadataClient siloMetadataClient,
     MembershipTableManager membershipTableManager,

src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadata.cs

@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using System.Collections.Immutable;
 
+#nullable enable
 namespace Orleans.Runtime.MembershipService.SiloMetadata;
 
 [GenerateSerializer]

src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadataClient.cs

@@ -2,6 +2,7 @@
 using System.Threading.Tasks;
 using Orleans.Runtime.Services;
 
+#nullable enable
 namespace Orleans.Runtime.MembershipService.SiloMetadata;
 
 public class SiloMetadataClient(IServiceProvider serviceProvider)

src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadataGrainService.cs

@@ -2,6 +2,7 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
+#nullable enable
 namespace Orleans.Runtime.MembershipService.SiloMetadata;
 
 public class SiloMetadataGrainService : GrainService, ISiloMetadataGrainService

src/Orleans.Runtime/MembershipService/SiloMetadata/SiloMetadataHostingExtensions.cs

@@ -6,6 +6,7 @@
 using Orleans.Placement;
 using Orleans.Runtime.Placement.Filtering;
 
+#nullable enable
 namespace Orleans.Runtime.MembershipService.SiloMetadata;
 
 public static class SiloMetadataHostingExtensions

src/Orleans.Runtime/Placement/Filtering/PlacementFilterDirectorResolver.cs

@@ -2,6 +2,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Orleans.Placement;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 /// <summary>

src/Orleans.Runtime/Placement/Filtering/PlacementFilterStrategyResolver.cs

@@ -6,6 +6,7 @@
 using Orleans.Metadata;
 using Orleans.Placement;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 /// <summary>

src/Orleans.Runtime/Placement/Filtering/PreferredMatchSiloMetadataPlacementFilterAttribute.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics.CodeAnalysis;
 using Orleans.Placement;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 /// <summary>

src/Orleans.Runtime/Placement/Filtering/PreferredMatchSiloMetadataPlacementFilterDirector.cs

@@ -3,6 +3,7 @@
 using System.Linq;
 using Orleans.Placement;
 using Orleans.Runtime.MembershipService.SiloMetadata;
+
 #nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 

src/Orleans.Runtime/Placement/Filtering/PreferredMatchSiloMetadataPlacementFilterStrategy.cs

@@ -3,6 +3,7 @@
 using Orleans.Metadata;
 using Orleans.Placement;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 public class PreferredMatchSiloMetadataPlacementFilterStrategy(string[] orderedMetadataKeys, int minCandidates, int order)
@@ -11,13 +12,18 @@ public class PreferredMatchSiloMetadataPlacementFilterStrategy(string[] orderedM
     public string[] OrderedMetadataKeys { get; set; } = orderedMetadataKeys;
     public int MinCandidates { get; set; } = minCandidates;
 
-    public PreferredMatchSiloMetadataPlacementFilterStrategy() : this([], 1, 0)
+    public PreferredMatchSiloMetadataPlacementFilterStrategy() : this([], 2, 0)
     {
     }
 
     public override void AdditionalInitialize(GrainProperties properties)
     {
-        OrderedMetadataKeys = GetPlacementFilterGrainProperty("ordered-metadata-keys", properties).Split(",");
+        var placementFilterGrainProperty = GetPlacementFilterGrainProperty("ordered-metadata-keys", properties);
+        if (placementFilterGrainProperty is null)
+        {
+            throw new ArgumentException("Invalid ordered-metadata-keys property value.");
+        }
+        OrderedMetadataKeys = placementFilterGrainProperty.Split(",");
         var minCandidatesProperty = GetPlacementFilterGrainProperty("min-candidates", properties);
         if (!int.TryParse(minCandidatesProperty, out var parsedMinCandidates))
         {

src/Orleans.Runtime/Placement/Filtering/RequiredMatchSiloMetadataPlacementFilterAttribute.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics.CodeAnalysis;
 using Orleans.Placement;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 /// <summary>

src/Orleans.Runtime/Placement/Filtering/RequiredMatchSiloMetadataPlacementFilterDirector.cs

@@ -3,6 +3,7 @@
 using Orleans.Placement;
 using Orleans.Runtime.MembershipService.SiloMetadata;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 internal class RequiredMatchSiloMetadataPlacementFilterDirector(ILocalSiloDetails localSiloDetails, ISiloMetadataCache siloMetadataCache)
@@ -28,7 +29,7 @@ public IEnumerable<SiloAddress> Filter(PlacementFilterStrategy filterStrategy, P
         });
     }
 
-    private static bool DoesMetadataMatch(string[] localMetadata, SiloMetadata siloMetadata, string[] metadataKeys)
+    private static bool DoesMetadataMatch(string?[] localMetadata, SiloMetadata siloMetadata, string[] metadataKeys)
     {
         for (var i = 0; i < metadataKeys.Length; i++)
         {
@@ -40,9 +41,9 @@ private static bool DoesMetadataMatch(string[] localMetadata, SiloMetadata siloM
 
         return true;
     }
-    private static string[] GetMetadata(SiloMetadata siloMetadata, string[] metadataKeys)
+    private static string?[] GetMetadata(SiloMetadata siloMetadata, string[] metadataKeys)
     {
-        var result = new string[metadataKeys.Length];
+        var result = new string?[metadataKeys.Length];
         for (var i = 0; i < metadataKeys.Length; i++)
         {
             result[i] = siloMetadata.Metadata?.GetValueOrDefault(metadataKeys[i]);

src/Orleans.Runtime/Placement/Filtering/RequiredMatchSiloMetadataPlacementFilterStrategy.cs

@@ -3,6 +3,7 @@
 using Orleans.Metadata;
 using Orleans.Placement;
 
+#nullable enable
 namespace Orleans.Runtime.Placement.Filtering;
 
 public class RequiredMatchSiloMetadataPlacementFilterStrategy(string[] metadataKeys, int order)
@@ -16,7 +17,12 @@ public RequiredMatchSiloMetadataPlacementFilterStrategy() : this([], 0)
 
     public override void AdditionalInitialize(GrainProperties properties)
     {
-        MetadataKeys = GetPlacementFilterGrainProperty("metadata-keys", properties).Split(",");
+        var placementFilterGrainProperty = GetPlacementFilterGrainProperty("metadata-keys", properties);
+        if (placementFilterGrainProperty is null)
+        {
+            throw new ArgumentException("Invalid metadata-keys property value.");
+        }
+        MetadataKeys = placementFilterGrainProperty.Split(",");
     }
 
     protected override IEnumerable<KeyValuePair<string, string>> GetAdditionalGrainProperties(IServiceProvider services, Type grainClass, GrainType grainType,