Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to deps.json change wrt PrivateAssets #35265

Open
AndriySvyryd opened this issue Dec 3, 2024 · 4 comments · May be fixed by #35527
Open

React to deps.json change wrt PrivateAssets #35265

AndriySvyryd opened this issue Dec 3, 2024 · 4 comments · May be fixed by #35527
Labels
area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Dec 3, 2024

dotnet/sdk#45259 removes PackageReferences with PrivateAssets="all" from the .deps.json. This means that by default EFCore.Design references will no longer be discovered by our tools.

@AndriySvyryd
Copy link
Member Author

@bricelam If that change does go through, I'm not sure that there's much that we can do other than documenting that EFCore.Design should be referenced directly from every project that would be targeted by tools.

@AndriySvyryd AndriySvyryd added this to the 10.0.0 milestone Dec 3, 2024
@bricelam
Copy link
Contributor

bricelam commented Dec 3, 2024

Using AssemblyLoadContext (mentioned in #18840) would be an alternative to calling dotnet exec with the project's .deps.json file. This would allow us (Edit: lol, I can't help myself; it just comes out. I mean you guys) to define where it gets loaded from.

@AndriySvyryd AndriySvyryd marked this as a duplicate of #35489 Jan 22, 2025
@baronfel
Copy link
Member

We're reverting that PR based on feedback from several partner teams, so 200 shouldn't blow up your expectations. Apologies for the close call, but please in the future yell at us if something we do has inordinate impact on your use cases.

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Jan 23, 2025

@baronfel Thanks, will do. We thought that we could react to it in a patch to avoid breaking the users, but I only got to it last week and found out that to be able to use AssemblyLoadContext we'd have to update our TFM.

We are still going to make this change for 10 anyway as it should make assembly loading more robust in general. And we already had a user report that presented the same symptoms.

@AndriySvyryd AndriySvyryd linked a pull request Jan 25, 2025 that will close this issue
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 27, 2025
@AndriySvyryd AndriySvyryd removed their assignment Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants