-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to deps.json change wrt PrivateAssets #35265
Comments
@bricelam If that change does go through, I'm not sure that there's much that we can do other than documenting that EFCore.Design should be referenced directly from every project that would be targeted by tools. |
Using AssemblyLoadContext (mentioned in #18840) would be an alternative to calling |
We're reverting that PR based on feedback from several partner teams, so 200 shouldn't blow up your expectations. Apologies for the close call, but please in the future yell at us if something we do has inordinate impact on your use cases. |
@baronfel Thanks, will do. We thought that we could react to it in a patch to avoid breaking the users, but I only got to it last week and found out that to be able to use We are still going to make this change for 10 anyway as it should make assembly loading more robust in general. And we already had a user report that presented the same symptoms. |
dotnet/sdk#45259 removes
PackageReferences
withPrivateAssets="all"
from the.deps.json
. This means that by defaultEFCore.Design
references will no longer be discovered by our tools.The text was updated successfully, but these errors were encountered: