From 2edf448f11cfc6ec109c33468050966d9e801633 Mon Sep 17 00:00:00 2001 From: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> Date: Thu, 3 Apr 2025 13:43:48 -1000 Subject: [PATCH 1/3] Typo in AuthenticationMetrics.cs description Copy/paste error? --- src/Http/Authentication.Core/src/AuthenticationMetrics.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Http/Authentication.Core/src/AuthenticationMetrics.cs b/src/Http/Authentication.Core/src/AuthenticationMetrics.cs index 12607938a10d..59079617d6c7 100644 --- a/src/Http/Authentication.Core/src/AuthenticationMetrics.cs +++ b/src/Http/Authentication.Core/src/AuthenticationMetrics.cs @@ -47,7 +47,7 @@ public AuthenticationMetrics(IMeterFactory meterFactory) _signOutCount = _meter.CreateCounter( "aspnetcore.authentication.sign_outs", unit: "{request}", - description: "The total number of times a scheme is signed out."); + description: "The total number of times a principal is signed out."); } public void AuthenticatedRequestCompleted(string? scheme, AuthenticateResult? result, Exception? exception, long startTimestamp, long currentTimestamp) From 0e3cb9c88a4e49ac2fcfbfcd7044758cdebfcc31 Mon Sep 17 00:00:00 2001 From: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> Date: Fri, 4 Apr 2025 09:18:55 -1000 Subject: [PATCH 2/3] Update src/Http/Authentication.Core/src/AuthenticationMetrics.cs Co-authored-by: Stephen Halter --- src/Http/Authentication.Core/src/AuthenticationMetrics.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Http/Authentication.Core/src/AuthenticationMetrics.cs b/src/Http/Authentication.Core/src/AuthenticationMetrics.cs index 59079617d6c7..223ec1d89810 100644 --- a/src/Http/Authentication.Core/src/AuthenticationMetrics.cs +++ b/src/Http/Authentication.Core/src/AuthenticationMetrics.cs @@ -47,7 +47,7 @@ public AuthenticationMetrics(IMeterFactory meterFactory) _signOutCount = _meter.CreateCounter( "aspnetcore.authentication.sign_outs", unit: "{request}", - description: "The total number of times a principal is signed out."); + description: "The total number of times a principal is signed out with a scheme."); } public void AuthenticatedRequestCompleted(string? scheme, AuthenticateResult? result, Exception? exception, long startTimestamp, long currentTimestamp) From cb02009a5d02a1371e15ce4bb10428ad9512c2da Mon Sep 17 00:00:00 2001 From: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com> Date: Fri, 4 Apr 2025 09:29:50 -1000 Subject: [PATCH 3/3] Update sign-in counter description --- src/Http/Authentication.Core/src/AuthenticationMetrics.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Http/Authentication.Core/src/AuthenticationMetrics.cs b/src/Http/Authentication.Core/src/AuthenticationMetrics.cs index 223ec1d89810..bb44be81f852 100644 --- a/src/Http/Authentication.Core/src/AuthenticationMetrics.cs +++ b/src/Http/Authentication.Core/src/AuthenticationMetrics.cs @@ -42,7 +42,7 @@ public AuthenticationMetrics(IMeterFactory meterFactory) _signInCount = _meter.CreateCounter( "aspnetcore.authentication.sign_ins", unit: "{request}", - description: "The total number of times a principal is signed in."); + description: "The total number of times a principal is signed in with a scheme."); _signOutCount = _meter.CreateCounter( "aspnetcore.authentication.sign_outs",