Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change DOTNET_ to ASPIRE_ in config variables #8009

Open
danmoseley opened this issue Mar 11, 2025 · 1 comment
Open

change DOTNET_ to ASPIRE_ in config variables #8009

danmoseley opened this issue Mar 11, 2025 · 1 comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone

Comments

@danmoseley
Copy link
Member

Variables that are unique to Aspire (ie., not things like DOTNET_ROOT) should use ASPIRE_ not DOTNET_ as Aspire is a platform and toolset for building polyglot apps, this seems more appropriate.

At the moment it seems like that's these - all should have

DOTNET_ASPIRE_CONTAINER_RUNTIME // change to ASPIRE_CONTAINER_RUNTIME, etc
DOTNET_ASPIRE_DEPENDENCY_CHECK_TIMEOUT
DOTNET_ASPIRE_SERVICE_STARTUP_WATCH_TIMEOUT
DOTNET_ASPIRE_SHOW_DASHBOARD_RESOURCES
DOTNET_DASHBOARD_CONFIG_FILE_PATH // change to ASPIRE_DASHBOARD_CONFIG_FILE_PATH
DOTNET_DASHBOARD_CORS_ALLOWED_ORIGINS
DOTNET_DASHBOARD_FILE_CONFIG_DIRECTORY
DOTNET_DASHBOARD_FRONTEND_BROWSERTOKEN
DOTNET_DASHBOARD_OTLP_ENDPOINT_URL
DOTNET_DASHBOARD_OTLP_HTTP_ENDPOINT_URL
DOTNET_DASHBOARD_RESOURCE_SERVER_ENDPOINT_URL
DOTNET_DASHBOARD_RESOURCESERVICE_APIKEY
DOTNET_DASHBOARD_UNSECURED_ALLOW_ANONYMOUS

this needs to be done while still recognizing the old names. I see env vars all over the code - it might be a good time to centralize into some utility class.

incidentally noticed this is missing an underscore

var isHttps = Environment.GetEnvironmentVariable("DOTNET_LAUNCHPROFILE") == "https";

@danmoseley danmoseley added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-dashboard labels Mar 11, 2025
@danmoseley danmoseley added this to the 9.2 milestone Mar 11, 2025
@danmoseley
Copy link
Member Author

cc @DamianEdwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

No branches or pull requests

1 participant