Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to start and stop containers and executables that aren't weren't fully initialized by DCP #5879

Closed
davidfowl opened this issue Sep 24, 2024 · 4 comments · Fixed by #7324 or #7329
Assignees
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone

Comments

@davidfowl
Copy link
Member

The 2 main scenarios are:

  • Ability to stop and restart a resource in the waiting state (it may be waiting for a dependency to start
  • Ability to start a resource that failed to start (e.g. a dependency load failure)
@davidfowl davidfowl added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication enhancement labels Sep 24, 2024
@davidfowl davidfowl changed the title Make it possible to start and stop resources that aren't DCP resources Make it possible to start and stop containers and executables that aren't weren't fully initialized by DCP Sep 24, 2024
@joperezr joperezr added the untriaged New issue has not been triaged label Oct 15, 2024
@davidfowl davidfowl added this to the Backlog milestone Oct 16, 2024
@joperezr joperezr removed the untriaged New issue has not been triaged label Oct 21, 2024
@joperezr joperezr modified the milestones: Backlog, 9.1 Jan 9, 2025
@JamesNK
Copy link
Member

JamesNK commented Jan 14, 2025

Ability to start a resource that failed to start (e.g. a dependency load failure)

What do you mean by this? I believe FailedToStart state resources can already be started.

The RuntimeUnhealthy can't be explicitly started from that state right now. Do you want it changed to allow the start command?

@JamesNK
Copy link
Member

JamesNK commented Jan 14, 2025

@karolz-ms Is there a situation where someone would want to be able to expliclty start a container via a resource command when the container is in a RuntimeUnhealthy state? I tested it out, and nothing happened, which is what I expected.

@davidfowl
Copy link
Member Author

This is about refactoring the code in application executor so that commands can restart the entire workflow in the apphost and not just call dcp

@karolz-ms
Copy link
Member

@karolz-ms Is there a situation where someone would want to be able to expliclty start a container via a resource command when the container is in a RuntimeUnhealthy state? I tested it out, and nothing happened, which is what I expected.

The RuntimeUnhealthy is a transient state for a container that is otherwise within the startup sequence (which includes building/fetching an image, creating, connecting to networks, and actual start, as necessary). It will be started automatically once the runtime becomes healthy again. So there is really no point in starting it manually, it won't change anything really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
4 participants