Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with child resources not visible by default #7258

Open
1 task done
afscrome opened this issue Jan 26, 2025 · 3 comments · May be fixed by #7404
Open
1 task done

Problems with child resources not visible by default #7258

afscrome opened this issue Jan 26, 2025 · 3 comments · May be fixed by #7404
Assignees
Milestone

Comments

@afscrome
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

In 9.1, the aspire dashboard by default collapses child resources. This is fine when everything works fine, but hides errors if they occurs

What you see when initially opening the dashboard - everything looks fine.
Image

What you see after expanding the sql server resource - the database is unhealthy.
Image

Expected Behavior

If a resource is in an abnormal state, I'd expect to see this somehow. Either by having resources expanded by default, or having some kind of aggregation / icon indicating something is abnormal about the sql resource, encouraging me to expand it

Steps To Reproduce

var sql = builder.AddSqlServer("sql")
    .WithLifetime(ContainerLifetime.Persistent)
    ;

var db = sql.AddDatabase("mydb");

builder.Services.AddHealthChecks().AddCheck(
    "unhealthy",
    () => HealthCheckResult.Unhealthy()
    );

db.WithHealthCheck("unhealthy");

Exceptions (if any)

No response

.NET Version info

.NET SDK:
 Version:           9.0.102
 Commit:            cb83cd4923
 Workload version:  9.0.100-manifests.6fec3956
 MSBuild version:   17.12.18+ed8c6aec5

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.26100
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\9.0.102\

.NET workloads installed:
 [aspire]
   Installation Source: VS 17.12.35707.178
   Manifest Version:    9.0.0-preview.4.24454.4/8.0.100
   Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\9.0.0-preview.4.24454.4\WorkloadManifest.json
   Install Type:              Msi

Configured to use loose manifests when installing new manifests.

Host:
  Version:      9.0.1
  Architecture: x64
  Commit:       c8acea2262

.NET SDKs installed:
  8.0.405 [C:\Program Files\dotnet\sdk]
  9.0.100-rc.2.24474.11 [C:\Program Files\dotnet\sdk]
  9.0.102 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 9.0.0-rc.2.24474.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 9.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.0-rc.2.24473.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 8.0.12 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 9.0.0-rc.2.24474.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 9.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

Anything else?

<PackageReference Include="Aspire.Hosting.AppHost" Version="9.1.0-preview.1.25075.3" />
@davidfowl davidfowl added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 27, 2025
@davidfowl davidfowl added this to the 9.1 milestone Jan 27, 2025
@davidfowl davidfowl added area-dashboard and removed area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication labels Jan 27, 2025
@davidfowl
Copy link
Member

@JamesNK @leslierichardson95 We should do this in 9.1

@JamesNK
Copy link
Member

JamesNK commented Jan 28, 2025

The simplest fix would be to expand child resources by default.

Also, we should have some persistence of expanded/collapsed resources so that if you collapse a resource, then navigate to another page and back again, the resource is still collapsed.

@afscrome
Copy link
Contributor Author

Also, we should have some persistence of expanded/collapsed resources so that if you collapse a resource, then navigate to another page and back again, the resource is still collapsed.

An "expand all" / "collapse all" option would be a nice companion to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants