Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run the dashboard behind a reverse proxy or load balancer #5134

Open
1 task done
fiotti opened this issue Aug 1, 2024 · 2 comments
Open
1 task done

Comments

@fiotti
Copy link

fiotti commented Aug 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

I would like to be able to host Aspire Dashboard behind a reverse proxy such as NGINX. Unfortunately, Aspire Dashboard doesn't take X-Forwarded-* headers into consideration, and doesn't allow to configure a path base.

As an example, assume Aspire Dashboard is accessible internally from http://aspire-dashboard-service:18888/ and externally from https://example.com/dev/aspire-dashboard/ through a reverse proxy.

The issue of the path base has already been described in #4528 and #4159. Additionally, authentication through OpenID Connect fails to set the correct value for redirect_uri, as it uses the internal schema (HTTP) rather than the external one (HTTPS).

Describe the solution you'd like

It's possible to add support for reverse proxies and load balancers as described here:
https://learn.microsoft.com/aspnet/core/host-and-deploy/proxy-load-balancer

Ideally, all the featured described in previous page (except for certificate forwarding) should be configurable by the user, namely:

  • Forwarded headers from the reverse proxy or load balancer
  • Header names, known proxies and forward limit
  • Forcing the assumption that external address is always HTTPS (necessary when the reverse proxy does not support X-Forwarded-* headers)
  • Path base

Additional context

No response

@davidfowl davidfowl changed the title Dashboard: add support for a reverse proxy or load balancer Make it possible to run the dashboard behind a reverse proxy or load balancer Sep 16, 2024
@joperezr joperezr added the untriaged New issue has not been triaged label Oct 15, 2024
ewassef added a commit to ewassef/aspire that referenced this issue Dec 18, 2024
This will allow the aspire app to handle running behind a reverse proxy such as a k8s ingress on a subpath
dotnet#4159
dotnet#4528
dotnet#5134
@ewassef
Copy link

ewassef commented Dec 18, 2024

I created a PR for this #6963

@fiotti
Copy link
Author

fiotti commented Dec 19, 2024

Keeping in mind that PR #6963 only adds "path base" support. This is not sufficient to close the issue described here.

@davidfowl davidfowl added this to the 9.1 milestone Jan 15, 2025
@davidfowl davidfowl removed the untriaged New issue has not been triaged label Jan 15, 2025
@davidfowl davidfowl modified the milestones: 9.1, Backlog Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants