Localize strings and pane/dialog dismissal titles (#7219)

* Add localized translations for required attributes

* Add dismiss titles to panes and dialogs

---------

Co-authored-by: Adam Ratzman <[email protected]>

Author: adamint

src/Aspire.Dashboard/Components/Controls/Chart/MetricTable.razor.cs

@@ -102,7 +102,7 @@ private async Task OpenExemplarsDialogAsync(MetricViewBase metric)
         var parameters = new DialogParameters
         {
             Title = DialogsLoc[nameof(Resources.Dialogs.ExemplarsDialogTitle)],
-            PrimaryAction = DialogsLoc[nameof(Resources.Dialogs.ExemplarsDialogCloseButtonText)],
+            PrimaryAction = DialogsLoc[nameof(Resources.Dialogs.DialogCloseButtonText)],
             SecondaryAction = string.Empty,
             Width = "800px",
             Height = "auto"

src/Aspire.Dashboard/Components/Layout/AspirePageContentLayout.razor

@@ -2,6 +2,7 @@
 
 @inject IStringLocalizer<Layout> LayoutLoc
 @inject IStringLocalizer<ControlsStrings> ControlsStringsLoc
+@inject IStringLocalizer<Dialogs> DialogsLoc
 
 <div class="content-layout">
     <!-- Toolbar -->

src/Aspire.Dashboard/Components/Layout/AspirePageContentLayout.razor.cs

@@ -83,6 +83,7 @@ public async Task OpenMobileToolbarAsync()
             {
                 Alignment = HorizontalAlignment.Center,
                 Title = MobileToolbarButtonText ?? ControlsStringsLoc[nameof(ControlsStrings.ChartContainerFiltersHeader)],
+                DismissTitle = DialogsLoc[nameof(Resources.Dialogs.DialogCloseButtonText)],
                 Width = "100%",
                 Height = "90%",
                 Modal = false,

src/Aspire.Dashboard/Components/Layout/MainLayout.razor.cs

@@ -158,6 +158,7 @@ private async Task LaunchHelpAsync()
         DialogParameters parameters = new()
         {
             Title = Loc[nameof(Resources.Layout.MainLayoutAspireDashboardHelpLink)],
+            DismissTitle = DialogsLoc[nameof(Resources.Dialogs.DialogCloseButtonText)],
             PrimaryAction = Loc[nameof(Resources.Layout.MainLayoutSettingsDialogClose)],
             PrimaryActionEnabled = true,
             SecondaryAction = null,
@@ -193,6 +194,7 @@ public async Task LaunchSettingsAsync()
         var parameters = new DialogParameters
         {
             Title = Loc[nameof(Resources.Layout.MainLayoutSettingsDialogTitle)],
+            DismissTitle = DialogsLoc[nameof(Resources.Dialogs.DialogCloseButtonText)],
             PrimaryAction =  Loc[nameof(Resources.Layout.MainLayoutSettingsDialogClose)].Value,
             SecondaryAction = null,
             TrapFocus = true,

src/Aspire.Dashboard/Components/Pages/StructuredLogs.razor

@@ -12,6 +12,7 @@
 @inject IStringLocalizer<Dashboard.Resources.StructuredLogs> Loc
 @inject IStringLocalizer<ControlsStrings> ControlsStringsLoc
 @inject IStringLocalizer<StructuredFiltering> FilterLoc
+@inject IStringLocalizer<Dialogs> DialogsLoc
 
 <PageTitle>
     <ApplicationName

src/Aspire.Dashboard/Components/Pages/StructuredLogs.razor.cs

@@ -285,6 +285,7 @@ private async Task OpenFilterAsync(TelemetryFilter? entry)
         {
             OnDialogResult = DialogService.CreateDialogCallback(this, HandleFilterDialog),
             Title = title,
+            DismissTitle = DialogsLoc[nameof(Dashboard.Resources.Dialogs.DialogCloseButtonText)],
             Alignment = HorizontalAlignment.Right,
             PrimaryAction = null,
             SecondaryAction = null,

src/Aspire.Dashboard/Components/Pages/Traces.razor

@@ -7,10 +7,13 @@
 @using Aspire.Dashboard.Utils
 @using System.Globalization
 @using Aspire.Dashboard.Components.Controls.Grid
+
 @inject IJSRuntime JS
 @inject IStringLocalizer<Dashboard.Resources.Traces> Loc
 @inject IStringLocalizer<StructuredFiltering> FilterLoc
 @inject IStringLocalizer<ControlsStrings> ControlsStringsLoc
+@inject IStringLocalizer<Dialogs> DialogsLoc
+
 @implements IDisposable
 
 <PageTitle>

src/Aspire.Dashboard/Components/Pages/Traces.razor.cs

@@ -301,6 +301,7 @@ private async Task OpenFilterAsync(TelemetryFilter? entry)
         {
             OnDialogResult = DialogService.CreateDialogCallback(this, HandleFilterDialog),
             Title = title,
+            DismissTitle = DialogsLoc[nameof(Dashboard.Resources.Dialogs.DialogCloseButtonText)],
             Alignment = HorizontalAlignment.Right,
             PrimaryAction = null,
             SecondaryAction = null,

src/Aspire.Dashboard/Model/Otlp/FilterDialogFormModel.cs

@@ -2,20 +2,21 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.ComponentModel.DataAnnotations;
+using Aspire.Dashboard.Resources;
 
 namespace Aspire.Dashboard.Model.Otlp;
 
 public class FilterDialogFormModel
 {
-    [Required]
+    [Required(ErrorMessageResourceType = typeof(Dialogs), ErrorMessageResourceName = nameof(Dialogs.FieldRequired))]
     public SelectViewModel<string>? Parameter { get; set; }
 
-    [Required]
+    [Required(ErrorMessageResourceType = typeof(Dialogs), ErrorMessageResourceName = nameof(Dialogs.FieldRequired))]
     public SelectViewModel<FilterCondition>? Condition { get; set; }
 
     // Set a max length on value because it will be added to the query string.
     // Max length is protection against accidently building a query string that exceeds limits because of a very long value.
-    [Required]
-    [MaxLength(1024)]
+    [Required(ErrorMessageResourceType = typeof(Dialogs), ErrorMessageResourceName = nameof(Dialogs.FieldRequired))]
+    [MaxLength(1024, ErrorMessageResourceType = typeof(Dialogs), ErrorMessageResourceName = nameof(Dialogs.FieldTooLong))]
     public string? Value { get; set; }
 }

src/Aspire.Dashboard/Resources/Dialogs.Designer.cs

@@ -211,7 +211,7 @@
   <data name="HelpDialogKeyboardShortcutsTitle" xml:space="preserve">
     <value>Keyboard Shortcuts</value>
   </data>
-  <data name="ExemplarsDialogCloseButtonText" xml:space="preserve">
+  <data name="DialogCloseButtonText" xml:space="preserve">
     <value>Close</value>
   </data>
   <data name="ExemplarsDialogTitle" xml:space="preserve">
@@ -254,4 +254,12 @@
   <data name="OpenInTextVisualizer" xml:space="preserve">
     <value>Open in text visualizer</value>
   </data>
+  <data name="FieldRequired" xml:space="preserve">
+    <value>A value is required.</value>
+    <comment>{0} is the literal, untranslated field name which we do not want to show, so it is missing.</comment>
+  </data>
+  <data name="FieldTooLong" xml:space="preserve">
+    <value>A maximum length of {1} characters is allowed.</value>
+    <comment>{0} is the field name, whereas {1} is the length. We don't want to show the field name, so it is missing.</comment>
+  </data>
 </root>