Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate 'Active Directory Password' authentication mode. #3219

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Deprecate 'Active Directory Password' authentication mode. #3219

merged 2 commits into from
Mar 17, 2025

Conversation

cheenamalhotra
Copy link
Member

Addresses #3188

@cheenamalhotra cheenamalhotra requested review from David-Engel and a team March 14, 2025 02:01
@cheenamalhotra cheenamalhotra linked an issue Mar 14, 2025 that may be closed by this pull request
Deprecate Authentication=ActiveDirectoryPassword #3188
Closed
@cheenamalhotra cheenamalhotra added this to the 7.0-preview1 milestone Mar 14, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.66%. Comparing base (1e59b88) to head (ec5e8fd).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3219      +/-   ##
==========================================
+ Coverage   72.58%   72.66%   +0.08%     
==========================================
  Files         289      288       -1     
  Lines       59503    59614     +111     
==========================================
+ Hits        43188    43318     +130     
+ Misses      16315    16296      -19
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.18% <100.00%> (+0.06%) ⬆️
netfx 71.27% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski
paulmedynski requested changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Asking to think about narrowing #pragma scope.

@cheenamalhotra cheenamalhotra merged commit 325ca56 into main Mar 17, 2025
252 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/cheena/deprecate-aad-pass branch March 17, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

Deprecate Authentication=ActiveDirectoryPassword
3 participants
@cheenamalhotra @David-Engel @paulmedynski