-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent CODEOWNERS pings for 'live' branch PRs #33627
Comments
Where is it, I'll delete it. |
I don't know if it's the right thing to do, except that I think the reason that pings are coming in from https://github.com/dotnet/AspNetCore.Docs/blob/live/.github/CODEOWNERS |
I don't see how deleting it from live can help -- I expect it'll just get added back with the next merge to live. |
You might be right. It shouldn't hurt to delete it and see what happens. We can 🎲🎲 ....... Roll the dice and take your chances! - Col. Nathan R. Jessep (Jack Nicholson) |
Not sure if it will get added back if it doesn't change on |
Fixed by #33655. |
@tdykstra @Rick-Anderson @wadepickett ... I think if the CODEOWNERS file isn't present on the
live
branch that GH will stop adding me as a reviewer for every Merge-to-Live PR that has a Blazor PR on it.BTW - The CODEOWNERS system for Blazor PRs is working great, so I'm not remarking on its use for
main
. I'm happy with it there.Can the CODEOWNERS file just be deleted from the
live
branch without it being regenerated?The text was updated successfully, but these errors were encountered: