Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CODEOWNERS pings for 'live' branch PRs #33627

Closed
guardrex opened this issue Sep 17, 2024 · 6 comments
Closed

Prevent CODEOWNERS pings for 'live' branch PRs #33627

guardrex opened this issue Sep 17, 2024 · 6 comments

Comments

@guardrex
Copy link
Collaborator

@tdykstra @Rick-Anderson @wadepickett ... I think if the CODEOWNERS file isn't present on the live branch that GH will stop adding me as a reviewer for every Merge-to-Live PR that has a Blazor PR on it.

BTW - The CODEOWNERS system for Blazor PRs is working great, so I'm not remarking on its use for main. I'm happy with it there.

Can the CODEOWNERS file just be deleted from the live branch without it being regenerated?

@Rick-Anderson
Copy link
Contributor

Where is it, I'll delete it.

@guardrex
Copy link
Collaborator Author

I don't know if it's the right thing to do, except that I think the reason that pings are coming in from live is because the file is on the live branch. I think that's how it works. I don't know if removing the file from that branch will work ... just guessing 🤔. The file is here on the live branch ...

https://github.com/dotnet/AspNetCore.Docs/blob/live/.github/CODEOWNERS

@tdykstra
Copy link
Contributor

I don't see how deleting it from live can help -- I expect it'll just get added back with the next merge to live.

@guardrex
Copy link
Collaborator Author

guardrex commented Sep 18, 2024

You might be right. It shouldn't hurt to delete it and see what happens. We can 🎲🎲 .......

jack

Roll the dice and take your chances! - Col. Nathan R. Jessep (Jack Nicholson)
"A Few Good Men" ©1992 Columbia Pictures, Castle Rock Entertainment

@guardrex
Copy link
Collaborator Author

get added back with the next merge to live

Not sure if it will get added back if it doesn't change on main. It might stay gone until the next time it gets an update.

@guardrex
Copy link
Collaborator Author

Fixed by #33655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants