Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNIPPETS-C++] Updated "Vector To Queue" #227

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

majvax
Copy link
Collaborator

@majvax majvax commented Jan 10, 2025

Description

  • The snippets was not following the guidelines.
  • It contained error, you can't pass by reference like that in c++
  • Updated it so it work with other type.

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

@majvax majvax requested a review from saminjay as a code owner January 10, 2025 20:31
@majvax majvax changed the title [SNIPPETS-C++] Updated a c++ snippet [SNIPPETS-C++] Updated a Vector To Queue Jan 10, 2025
@majvax majvax changed the title [SNIPPETS-C++] Updated a Vector To Queue [SNIPPETS-C++] Updated "Vector To Queue" Jan 10, 2025
Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Mathys-Gasnier Mathys-Gasnier merged commit 48048cd into technoph1le:main Jan 12, 2025
2 checks passed
@majvax majvax deleted the fix-snippet branch January 13, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants