Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python snippet for calculating factorial #221

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

SamratBarai
Copy link
Contributor

Description

Type of Change

  • ✨ New snippet
  • πŸ›  Improvement to an existing snippet
  • 🐞 Bug fix
  • πŸ“– Documentation update
  • πŸ”§ Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! πŸ‘

I appreciate you catching that error in our existing snippets - this kind of attention to detail really helps maintain quality.

However, regarding the factorial calculation snippets you've proposed: while well-implemented, they don't align with our current quicksnip scope. Factorial calculations are relatively simple operations that only require basic math knowledge and are straightforward to implement.

could you remove the factorial function so we can merge the rest ?

@majvax majvax added the enhancement New feature or request label Jan 9, 2025
@majvax majvax merged commit 464e50a into technoph1le:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants