adding eslint and making fixes

Author: dominicbarnes

.eslintrc

@@ -0,0 +1,11 @@
+{
+  "extends": [
+    "@dominicbarnes",
+    "@dominicbarnes/node"
+  ],
+  "rules": {
+    "global-require": 0,
+    "no-console": 0,
+    "no-process-exit": 0
+  }
+}

bin/_duo-tester

@@ -61,15 +61,17 @@ if (!program.args.length) program.help();
  * @param {Function} runner
  */
 
-function run(runner, files, options) {
-  var runner = require('../lib/' + runner);
+function run(id, files, options) {
+  var runner = require('../lib/' + id);
   var root = options.parent.root;
   var entries = getEntries(files, root);
   var plugins = getPlugins(options.parent.use, root);
+  var port = options.parent.port;
 
   runner(entries, {
     root: root,
-    plugins: plugins
+    plugins: plugins,
+    port: port
   });
 }
 

lib/browser.js

@@ -13,8 +13,6 @@ var serve = require('duo-serve');
  */
 
 module.exports = function (entries, options) {
-  var url = 'http://localhost:' + options.port + '/';
-
   var server = serve(options.root)
     .entry(entries)
     .html(html)
@@ -32,7 +30,7 @@ module.exports = function (entries, options) {
 
   server.listen(options.port, function () {
     console.log();
-    console.log('  duo-tester running at %s', url);
+    console.log('  duo-tester running at http://localhost:%d/', options.port);
     console.log();
   });
 };

lib/phantom.js

@@ -16,8 +16,6 @@ var spawn = require('win-spawn');
  */
 
 module.exports = function (entries, options) {
-  var url = 'http://localhost:' + options.port + '/';
-
   var server = serve(options.root)
     .entry(entries)
     .favicon(false)
@@ -35,13 +33,12 @@ module.exports = function (entries, options) {
       res.sendFile(path.resolve(mocha, '../mocha.js'));
     });
 
-  server.listen(options.port, start);
-};
-
-function start() {
-  var proc = spawn(phantomjs.path, [ script, url ], { stdio: 'inherit' });
+  server.listen(options.port, function () {
+    var url = 'http://localhost:' + options.port + '/';
+    var proc = spawn(phantomjs.path, [ script, url ], { stdio: 'inherit' });
 
-  proc.on('exit', function (code) {
-    process.exit(code);
+    proc.on('exit', function (code) {
+      process.exit(code);
+    });
   });
-}
+};

package.json

@@ -12,7 +12,15 @@
     "mocha-phantomjs": "^3.5.3",
     "win-spawn": "^2.0.0"
   },
+  "devDependencies": {
+    "@dominicbarnes/eslint-config": "*",
+    "@dominicbarnes/eslint-config-node": "*",
+    "@dominicbarnes/eslint-config-test": "*",
+    "eslint": "^1.10.3",
+    "eslint-plugin-require-path-exists": "^1.0.25"
+  },
   "scripts": {
+    "lint": "eslint bin lib",
     "hooks": "cp scripts/hooks/* .git/hooks/"
   }
 }

test/.eslintrc

@@ -0,0 +1,3 @@
+{
+  "extends": "@dominicbarnes/test"
+}

test/index.js

@@ -0,0 +1,6 @@
+
+describe('smoke test', function () {
+  it('should not explode', function () {
+    assert.equal(2 + 2, 4);
+  });
+});

test/sum.js

@@ -0,0 +1,4 @@
+
+module.exports = function (a, b) {
+  return a + b;
+};