Decoupling the color picker + matching to UI3

[tigranpetrossian]

Hi @dokozero,

I've been working on https://github.com/tigranpetrossian/figma-kit/ for a little while now, and have been looking at your implementation as the color picker is pretty much the last missing piece.

Instead of just "borrowing" your implementation, I thought it might be a good idea to kill two birds with one stone by decoupling the color picker area (SV/SL/LC box) from okcolor into its own component, and improving the plugin itself while at it: using the color from the document now that Figma added it plugin API, re-considering hardware acceleration fallback, possibly using figma-kit's components as a base.

Is this something you'd be interested in? I suppose I could do most of the heavy lifting, as long as I have answers to few questions about certain parts of the implementation.

[dokozero]

Hi @tigranpetrossian,

Thanks for your message, I've checked your library and it seems promising. I can see from the Storybook that you have already implemented a color picker. 

A library like this would indeed be quite beneficial for the Figma plugin development world, I know there are others, but that seems not maintained or lack some components (I tried to use one when started OkColor, but it was missing some components / features, and it was not receiving updates, so ended up doing the UI from scratch).

However, for now, it seems better to me that you focus on your library and make it the best one out there 🙂 , then I'll see if we can use it to improve the plugin, especially to move it to the new UI3. Feel free of course to take any code from the plugin that you like for your library.

As from my side, right now I can't work on OkColor (nor give insights about its implementation) as I'm quite busy with another significant project that is about to end, I should then be able to continue the tasks on my todo list, notably to get the current file color profile from Figma automatically, which is, I think, what you mean by "using the color from the document [...]"?

Regarding "re-considering hardware acceleration fallback", for me this is less important, as the WebGL implementation works for the majority of users, I don't think time should be spent on this as the current fallback is good enough, unless of course you have some tips to easily make it faster without redoing the whole fallback code.

[tigranpetrossian]

Hey @dokozero,

No worries, my plan is exactly to re-use the shader logic in figma-kit's picker. If you ever decide to to work on OkColor again, I'm happy to help.