Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop modprobe hack #524

Open
tianon opened this issue Jan 23, 2025 · 0 comments
Open

Drop modprobe hack #524

tianon opened this issue Jan 23, 2025 · 0 comments

Comments

@tianon
Copy link
Member

tianon commented Jan 23, 2025

In ancient times, we merged #90 to add a fake modprobe that does ip link show to successfully load kernel modules on the host from inside a container.

Since moby/moby#49038 (v28+), this is implemented in dockerd itself, and was even backported in v27.4.1, which covers all supported versions and we could now (finally!) remove that code completely.

One wrinkle we have to consider/account for is all the complicated iptables-legacy logic we now have (where we use modprobe directly). Maybe that means we don't get to remove this code yet until we remove that code too?

(thanks to @thaJeztah for reminding me in docker/docker-ce-packaging#1118 (comment) and inspiring this issue ❤️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant