Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: High Urgency: Cannot set anymore folder permissions except for All users and Registered users #6391

Open
2 tasks done
fablaser opened this issue Feb 20, 2025 · 9 comments

Comments

@fablaser
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Hello,
I am using DNN 09.13.07. I discovered that it's not possible anymore to set folder permissions for custom roles. Only All users and Registered users work.

I just created a new folder with "Secure" option. By default I see "Browse" and "View " for "All users". It's ok.

Image

Then I tried to set Browse, View and Write for Registered users, and it works.

Image

Then I added a custom role permissions but they are not saved!

Image

When I come back to folder permissions I see no entries for custom role and I see that in FolderPermission sql table there are no rows related to the role I used,

Steps to reproduce?

  1. Create new folder with Secure option
  2. Add permission for a custom role
  3. Save
  4. Come back to folder permission and you will see that the options are not saved

Current Behavior

No permission are saved for custom role

Expected Behavior

Permission should be saved for custom roles

Relevant log output

Anything else?

No response

Affected Versions

9.13.7 (alpha)

What browsers are you seeing the problem on?

Firefox, Chrome

Code of Conduct

  • I agree to follow this project's Code of Conduct
@valadas valadas added this to the 9.13.8 milestone Feb 20, 2025
@jeremy-farrance
Copy link
Contributor

I tested this in DNN v10 RC1, same problem there also.

@kevinwolter
Copy link

I have also been experiencing the same issue since late 2023. Many of the sites I support use role-based file permissions. While it is possible to adjust the FolderPermission table directly, having the GUI working again would be ideal.

I see this has been moved as a bug in 9.13.8, so I hope it will be addressed soon. Role-based file permissions are a feature of DNN that I have always found exceptionally useful and a great selling point in using DNN.

@jeremy-farrance
Copy link
Contributor

I just tested this in RC2 of DNN v10 and its still a problem there too.

@valadas, Am I correct that if this gets fixed in 9.13.08, that the fix will also definitely end up in v10?

@valadas
Copy link
Contributor

valadas commented Feb 26, 2025

Yes, if a fix is submitted before 9.13.8 goes out of RC (about a week if there are no regressions)

@valadas valadas modified the milestones: 9.13.8, Future: Minor Feb 26, 2025
@valadas
Copy link
Contributor

valadas commented Feb 26, 2025

I actually just changed the milestone to any minor version, it all depends when a fix is submitted.

@jeremy-farrance
Copy link
Contributor

@valadas - given how/where the error is happening, I would be surprised if anyone could fix this except you.

If someone else is reading this, please accept that as a challenge!! :)

@jeremy-farrance
Copy link
Contributor

Also, here are the two duplicates of this issue that I know about. And they have a LOT of additional details and steps to reproduce.

Nov 2024: Issue #6318 - [Bug]: DNN Resource Manager Permissions Broken

Nov 2023: Issue #5857 - [Bug]: Resource Manager Error: cannot Add or Remove Permissions on Folders

@valadas
Copy link
Contributor

valadas commented Feb 27, 2025

@jeremy-farrance anyone can tackle this issue that knows basics of javascript/typescript.

Since this is an open-source project, it is maintained for free by developers that invest their free time generously. Most will (rightly so) scratch their own itch and prioritize issues that affect them or their clients. In my case this issue does not really affect me as I don't use custom roles for folder permissions. So, if this has to be on my docket, I'll get to it when I get to it. If anyone is in more of a rush and wants to sponsor a fix quicker, I do have many sponsorship options in my profile, but I would still have at least 1 week wait, so can't guarantee delivery in any specific version of DNN.

@jeremy-farrance
Copy link
Contributor

... If anyone is in more of a rush and wants to sponsor a fix quicker, ...

@valadas I think its possible to get someone to come with some donations$ or sponsorship to add a new feature or enhancement. But I would not be comfortable asking a client to pay to fix a bug (that most people see as "high urgency").

Since we have work-around (SQL), we'll continue to wait. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants