Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Faulty MoveTabAfter and MoveTabBefore logic #6384

Open
2 tasks done
timi-ty opened this issue Feb 17, 2025 · 1 comment · May be fixed by #6385
Open
2 tasks done

[Bug]: Faulty MoveTabAfter and MoveTabBefore logic #6384

timi-ty opened this issue Feb 17, 2025 · 1 comment · May be fixed by #6385

Comments

@timi-ty
Copy link

timi-ty commented Feb 17, 2025

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

The procedures: MoveTabBefore and MoveTabAfter, in https://github.com/dnnsoftware/Dnn.Platform/blob/develop/DNN%20Platform/Website/Providers/DataProviders/SqlDataProvider/DotNetNuke.Data.SqlDataProvider do not work correctly in case several tabs (pages) of a parent have the same TabOrder value. It is then not possible to insert a tab into the series of pages with the same TabOrder value.

Steps to reproduce?

  1. Go to the content tab on the admin panel
  2. Click on 'Pages'
  3. Create two or more pages with the same TabOrder value (change the TabOrder value within the database as this change cannot be performed explicitly from the UI)
  4. Move a page of a different TabOrder value, between two pages of the same TabOrder value.
  5. Refresh the site

Current Behavior

Home, 404 Error Page, Page One, and Page Two have the same TabOrder value. Attempting to move Activity Feed with a different TabOrder value, between them, fails.

The page with a different TabOrder value (Activity Feed) is moved above all tabs with the same TabOrder value.

Image
Image
Image

Expected Behavior

Activity Feed should be in between 404 Error Page and Page One

Relevant log output

Anything else?

No response

Affected Versions

9.13.6 (latest release)

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bdukes
Copy link
Contributor

bdukes commented Feb 17, 2025

Do you know what caused you to get into a scenario where the TabOrder of multiple pages was the same? As you noted, there's not a UI that should allow you to get into that scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants