Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Move privacy, terms and others from language resources into default pages #6373

Open
2 of 4 tasks
enfJoao opened this issue Feb 10, 2025 · 3 comments
Open
2 of 4 tasks

Comments

@enfJoao
Copy link

enfJoao commented Feb 10, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

In order to change these pages, new users have to navigate to language resources (very hidden feature) and edit the content in a text box.

Description of solution

The same way DNN ships with some default pages (home page, activity feed, etc), perhaps it should also include one page for each of these options, where admins could easily see, edit, replace or delete the content.
Every resource field with rich text could benefit from this.

As it is, users are redirected to these virtual pages that they cannot edit and cannot access (they are not on the page list).

They will have the option to create these pages manually and set them in site settings behavior, but it would be a nice start touch.

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
@valadas
Copy link
Contributor

valadas commented Feb 10, 2025

Users can already create their own pages for that and set those in Site Settings like so

Image

But we still need a fallback as not every theme can be assured to have those pages in their templates or even existing sites to have those pages upon upgrades. Then even if that worked we would have to maintain all the localizations ourselves.

@valadas valadas closed this as completed Feb 10, 2025
@bdukes
Copy link
Contributor

bdukes commented Feb 10, 2025

I think it's worth further discussion around whether it makes sense to include privacy and terms pages in the default template. It would simplify things for a lot of users if it was in place by default. There would still be the ability to remove them and use the virtual/fallback URL, but most site administrators would benefit by seeing that page out-of-the-box.

@bdukes bdukes reopened this Feb 10, 2025
@enfJoao
Copy link
Author

enfJoao commented Feb 10, 2025

The perspective for new users is very different than the one from a DNN veteran.

A newcomer will see existing content from terms or privacy, but will go around for hours trying to figure out why this content that seems a page is not on the page list. And clicking the edit page on that content does nothing.

The language resources setings will be dark magic for a very long time.

Terms and privacy are content, not resources to be translated by the CMS resources. And it will need to be changed in every installation, not by translation needs, but for content adaptation to the company. So the need to create a custom page for terms and provacy will emerge 99% of use cases, anyway. Might as well ship DNN with the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants