Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up and refactor WM Core build tools #12256

Open
vkuznet opened this issue Feb 10, 2025 · 0 comments · May be fixed by #12259
Open

Clean-up and refactor WM Core build tools #12256

vkuznet opened this issue Feb 10, 2025 · 0 comments · May be fixed by #12259
Assignees
Labels
High Priority New Feature Python3 Technical Debt Used to track issues that address technical needs internal to WM team

Comments

@vkuznet
Copy link
Contributor

vkuznet commented Feb 10, 2025

Impact of the new feature
Unify and make complaint WM Core setup tools with Python PEP-625 requirements.

Is your feature request related to a problem? Please describe.
At the moment the WMCore codebase contains a mix of setup files which relies on different technologies, e.g.

  • setup.py depends on distutils
  • setup_template.py depends on setuptools
  • setup_test.py depends on distutils
  • setup_wmcore.py depends on setuptools

In addition the above files uses setup_build.py and setup_dependencies.py. Our GitHub Actions are using setup.py while tools/build_pypi_packages.sh uses setup_template.py to create its own version of setup.py.

It would be useful to streamline usage of different setup files, and settle down on one procedure used across GitHub Actions, build tools and docker files (which also contains mix of Dockerfile and Dockerfile.dist who use different setup files)

Describe the solution you'd like
This ticket should address three main issues:

  • clarify, clean-up and refactor usage of setup files. We should converge on using setuptools as it is complaint with PEP-625
  • perform clean-up of all Dockerfiles with CMSKubernetes/docker/pypi area to settle on single approach (Dockerfile vs Dockerfile.dist)
  • and document build procedures in GitHub actions, building docker images and local deployment (if any)

Describe alternatives you've considered
Keep using all setup files as is

Additional context
This ticket is related to comply with PEP-625 requirements described in #12181

@amaltaro amaltaro added Technical Debt Used to track issues that address technical needs internal to WM team Python3 labels Feb 10, 2025
@amaltaro amaltaro moved this from ToDo to In Progress in WMCore quarterly developments Feb 10, 2025
@vkuznet vkuznet linked a pull request Feb 11, 2025 that will close this issue
@vkuznet vkuznet added High Priority Technical Debt Used to track issues that address technical needs internal to WM team Python3 and removed Python3 Technical Debt Used to track issues that address technical needs internal to WM team labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority New Feature Python3 Technical Debt Used to track issues that address technical needs internal to WM team
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants