changes done as per review comments

Author: Bhupesh-mfsi

packages/backend/src/config/getDeliveryServiceProperties.ts

@@ -10,11 +10,11 @@ const DEFAULT_DELIVERY_SERVICE_PROPERTIES: DeliveryServiceProperties = {
     //100Kb
     sizeLimit: 100000,
     notificationChannel: [],
-    smtpHost: process.env.SMTP_HOST as string,
-    smtpPort: Number(process.env.SMTP_PORT),
-    smtpEmail: process.env.SMTP_EMAIL as string,
-    smtpUsername: process.env.SMTP_USERNAME as string,
-    smtpPassword: process.env.SMTP_PASSWORD as string,
+    smtpHost: '',
+    smtpPort: 0,
+    smtpEmail: '',
+    smtpUsername: '',
+    smtpPassword: '',
 };
 
 export function getDeliveryServiceProperties(

packages/lib/delivery/src/notifications/channels/Email.ts

@@ -3,7 +3,7 @@ import { logError } from '@dm3-org/dm3-lib-shared';
 import nodemailer from 'nodemailer';
 import SMTPTransport from 'nodemailer/lib/smtp-transport';
 import { NotificationType } from '../types';
-import { fetchEmailSubjectAndTemplate } from '../utils';
+import { fetchEmailSubjectAndTemplate } from '../getEmailTemplate';
 
 // email server configuration
 export type EmailNotificationServerConfig = {

packages/lib/delivery/src/notifications/generateOtp.ts

@@ -0,0 +1,4 @@
+// TODO: generates 5 digit OTP
+export const generateOtp = () => {
+    return '12345';
+};

packages/lib/delivery/src/notifications/utils.ts packages/lib/delivery/src/notifications/getEmailTemplate.ts

@@ -5,11 +5,7 @@ import {
     NEW_MSG_EMAIL_TEMPLATE,
 } from './templates/newMessage';
 import { OTP_EMAIL_SUBJECT, OTP_EMAIL_TEMPLATE } from './templates/otp';
-
-// TODO: generates 5 digit OTP
-export const generateOtp = () => {
-    return '12345';
-};
+import { generateOtp } from './generateOtp';
 
 // to fetch subject & template of email based on notification type
 export const fetchEmailSubjectAndTemplate = (