Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE UNTIL DMD 2.111 IS RELEASED] remove dyaml.stdsumtype #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Herringway
Copy link
Member

Use phobos's std.sumtype.

DMD 2.111 may possibly be released late this year. Opening early just to run the CI and make sure things haven't diverged too much.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (8b18bb0) to head (e431706).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   93.74%   93.81%   +0.07%     
==========================================
  Files          29       28       -1     
  Lines        4570     4126     -444     
==========================================
- Hits         4284     3871     -413     
+ Misses        286      255      -31     
Files Coverage Δ
source/dyaml/node.d 91.06% <ø> (-0.80%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b18bb0...e431706. Read the comment docs.

@Herringway Herringway linked an issue Jan 18, 2025 that may be closed by this pull request
@dejlek
Copy link

dejlek commented Mar 21, 2025

IMHO you should modify the dub.json file and specify that frontend version must be >= 2.111

Something like:

{
    "toolchainRequirements": {
        "frontend": ">=2.111"
    }
}

This is why I do not like JSON for these things, as I would put a comment there // switched to use std.sumtype so whoever reads the dub.json file understands why we have that constraint...

@Herringway
Copy link
Member Author

We don't require 2.111. We just wait several versions to make breaking changes.

@dejlek
Copy link

dejlek commented Mar 21, 2025

So you would rather see someone who uses an old (few months even) compiler and see bunch of errors instead of DUB saying "you are using incompatible frontent, required version >=2.111" or something similar?

@Herringway
Copy link
Member Author

The last compiler to fail compiling dyaml will be several years old by that point, and not even debian stable supports it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove copy of std.sumtype
2 participants