Skip to content

Commit a8774ab

Browse files
committed
Fixed docker image and added comments after review
1 parent 96f7860 commit a8774ab

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/tests.yml

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ permissions:
1515

1616
env:
1717
DJANGO_SETTINGS_MODULE: tracdjangoplugin.settings_tests
18+
# passlib has a conditional import for `crypt` which is going away in python 3.13
19+
# and therefore throwing warnings
1820
PYTHONWARNINGS: >
1921
error,
2022
default:::passlib.utils,

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# pull official base image
2-
FROM python:3.12-slim-bookworm
2+
FROM python:3.11-slim-bookworm
33

44
# set work directory
55
WORKDIR /code

requirements.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ psycopg2==2.9.9 --no-binary=psycopg2
55
Django==4.2.16
66
libsass==0.23.0
77

8-
# Optional Trac dependencies that make DeprecationWarning go away
8+
# Optional Trac dependencies that make DeprecationWarning go away.
9+
# When upgrading Trac or Python, check if these dependencies are still needed
10+
# by uninstalling them and running the test suite (or CI) with PYTHONWARNINGS=error
911
multipart==1.1.0
1012
passlib==1.7.4
1113

0 commit comments

Comments
 (0)