Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker image public #192

Open
jcoelho93 opened this issue Feb 18, 2025 · 7 comments
Open

Make Docker image public #192

jcoelho93 opened this issue Feb 18, 2025 · 7 comments

Comments

@jcoelho93
Copy link
Contributor

jcoelho93 commented Feb 18, 2025

Hi, you started publishing the docker image to ghcr.io here: #174, but the image is still private so we can't reallly use it.

Could you please make the image public? Also the action.yml file must be changed so that the action uses the pre-built image instead of building it everytime.

Docs for reference: https://docs.github.com/en/packages/learn-github-packages/configuring-a-packages-access-control-and-visibility#configuring-visibility-of-packages-for-an-organization

@markusthoemmes
Copy link
Contributor

Ah, sorry, this fell between the cracks.

Sadly, due to internal policy on the digitalocean org, we won't be making packages (which includes these images) public as that requires an org-wide change. Sorry for the inconvenience, we should've checked this before approving and merging the respective changes.

For now, we'll stay on the "build on demand" model that's implemented already.

@jcoelho93
Copy link
Contributor Author

jcoelho93 commented Feb 21, 2025

@markusthoemmes :/ you could publish to digitalocean's DockerHub namespace instead. This is spending my CICD credits unnecessarily.

@tobyselway
Copy link

tobyselway commented Feb 27, 2025

I believe I may have a solution for this.

https://github.com/tobyselway/app_action

This builds on demand, but then stores the resulting binaries in the action user's cache, and reuses it on subsequent runs.

If you want to iterate on this with me, let me know and I'll open up a PR

@markusthoemmes
Copy link
Contributor

We're revisiting as we speak. @tobyselway that approach seems interesting as well! I'll take that into account. I wonder if we even need the Dockerfile in that world 🤔 . We could just built the go binary using the setup-go action there, I'd think?

@markusthoemmes
Copy link
Contributor

https://full-stack.blend.com/how-we-write-github-actions-in-go.html seems quite relevant and interesting as well.

@tobyselway
Copy link

We're revisiting as we speak. @tobyselway that approach seems interesting as well! I'll take that into account. I wonder if we even need the Dockerfile in that world 🤔 . We could just built the go binary using the setup-go action there, I'd think?

Yes, almost definitely

@markusthoemmes
Copy link
Contributor

The blog post I linked suggests that using setup-go is not a good idea as it might override whatever Golang version the users are setting for their flow. That seems to make sense to me.

TBC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants