You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We want to show a user all vocabulary, she has access to. E.g. lunes-standard and protected by api-key1 and protected by api-key2.
Currently there is only the option to:
call /api/words endpoint, getting all lunes standart vocabulary
call api/words with ONE api-key, getting all lunes standard vocabulary plus the vocabulary of ONE custom disicpline.
But if a user has two api-keys we would have to filter a lot of duplicates and as there is a lot of data, i think it is to slow.
Proposed Solution
Make it possible to add more than one api-key to the request (I guess this is not possible as the api-keys are send with the Auth-Header).
Alternatives
Only send custom words if api/words is called with api-key.
How urgent is this? This would be implicitly solved by API version 2 (#376).
I also suggested to think of the keys more as filters for the API than an actual secrets and to pass them as GET-parameters instead of the auth header for the next API version, which would also make it easy to pass multiple keys.
Not really urgent, as long as we do not have it, only lunes standard vocabulary is show in the dictionary, but I think this is fine, as there is almost no really actively used custom discipline right now.
Moving keys to the get-parameters sounds reasonable.
Motivation
We want to show a user all vocabulary, she has access to. E.g. lunes-standard and protected by api-key1 and protected by api-key2.
Currently there is only the option to:
/api/words
endpoint, getting all lunes standart vocabularyapi/words
with ONE api-key, getting all lunes standard vocabulary plus the vocabulary of ONE custom disicpline.But if a user has two api-keys we would have to filter a lot of duplicates and as there is a lot of data, i think it is to slow.
Proposed Solution
Make it possible to add more than one api-key to the request (I guess this is not possible as the api-keys are send with the Auth-Header).
Alternatives
Only send custom words if
api/words
is called with api-key.Additional Context
Users have a dictionary where they can search in all words.
Releated to: #405
App-issue: https://issues.tuerantuer.org/browse/LUN-434
The text was updated successfully, but these errors were encountered: