Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup #8538 -- correct rounding modes for floor, trunc #8597

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fixup #8538 -- correct rounding modes for floor, trunc #8597

wants to merge 1 commit into from

Conversation

kroening
Copy link
Member

@kroening kroening commented Feb 19, 2025 •
edited
Loading

This fixes the rounding modes used for the floor and trunc C library functions.

Fixes #8596.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (159af34) to head (968c28f).

Files with missing lines Patch % Lines
src/util/simplify_expr_floatbv.cpp 71.42% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8597      +/-   ##
===========================================
- Coverage    79.57%   79.53%   -0.05%     
===========================================
  Files         1733     1733              
  Lines       197826   197958     +132     
  Branches     18197    18193       -4     
===========================================
+ Hits        157421   157438      +17     
- Misses       40405    40520     +115

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening force-pushed the fixup-8538 branch 2 times, most recently from 177f33b to 2bf5ced Compare February 20, 2025 10:31
@kroening kroening marked this pull request as ready for review February 20, 2025 10:31
@tautschnig
Copy link
Collaborator

I am not sure what to make of the macOS 13 failures?

@kroening
Copy link
Member Author

I am not sure what to make of the macOS 13 failures?

No idea either. Might be an issue with the signbit implementation in math.h.

@kroening
Copy link
Member Author

I am not sure what to make of the macOS 13 failures?

Now disabled on macOS < 15 via preprocessor.

@kroening
fixup #8538 -- correct rounding modes for floor, trunc
968c28f 
This fixes the rounding modes used for the floor and trunc C library functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in floating-point floor
2 participants
@kroening @tautschnig