-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single point version definition #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR. Changes look good. There is only the part about independent versioning of IGUANA binaries and ontology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR. Changes look good to me. I just have two small comments.
src/main/java/org/aksw/iguana/cc/controller/MainController.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/resources/iguana.owx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Ready to merge.
Versioning:
schema/iguana.owx
tosrc/main/resources/iguana.owx
and updated theversionIRI
to use the${revision}
placeholder (ontology version will be equal to the version of IGUANA)graalvm/generate-profile.sh
to remove hardcoded version numbers and use dynamic naming for instrumented and PGO builds.iguana.owx
to the resources section inpom.xml
for proper inclusion during the build process.Deployment Workflow Updates:
Cleanup