-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify chain / network on RGB invoice #362
Comments
Hi @cryptoquick and @josediegorobles , we can make solve it, if add optional parameter in invoice called network. This maintain compatibility with other wallets and prevents the problem use invoices in wrong network. Does make sense? |
This should already be on the RGB invoice struct |
Yes, but it is only used in case you know the beneficiary (see here). |
So, that would be an invoice that includes a blinded UTXO? That's fine I think. |
No, RgbInvoice parse the chain only when beneficiary is a bitcoin address, not when a blind UTXO |
I see. You're right, we may need to add an optional parameter to the invoice then. I'll also tag @dr-orlovsky and @fedsten on this issue so they're aware of the issue. |
Different from #360; We need to verify if an invoice for the wrong network has been provided, and return an error if that is the case. We'll also need tests, and the necessary upstream functionality.
The text was updated successfully, but these errors were encountered: