Apple Silicon build

[kklobe]

If anyone's interested in an Apple Silicon build, I've got one running. It seems to be working fine; I've also been able to create and join network games with a Windows machine on the same network.

[AJenbo]

Could you post it here?

[AJenbo]

If there's a donate button somewhere here, I'll find it.

There is not.

@kklobe sorry, don't know much about that, I don't pay for an Apple developer license so don't have access to do so either.

[kklobe]

@AJenbo ah, gotcha - who creates/tests the x86-64 Mac build? It would be great to get the arm64 variant able to build automatically from the same sources.

[AJenbo]

I did, but it's not signed by someone paying blood money to Apple so it will ask for permissions before it will be allowed to run.

[kklobe]

haha! ok, so, for an Apple Silicon binary, macOS does require a codesign, but, it can be done with the ad-hoc identity "-", no blood money required. Without a code signature, it will get the "damaged" error that Bozone was seeing with my first attempt (it will still ask for permissions with a valid codesign, which is perfectly acceptable IMHO).

What seems to happen is that fixup_bundle breaks the codesigning on the dylibs as it copies them into Frameworks. I then inserted a manual codesign command like this:

  if(DIST)
      install(CODE "
        include(BundleUtilities)
        fixup_bundle(${CMAKE_BINARY_DIR}/${MACOSX_BUNDLE_BUNDLE_NAME}.app \"\" \"\")
        "
        COMPONENT Runtime)
      install(CODE "execute_process(COMMAND codesign -s \"-\" ${CMAKE_BINARY_DIR}/${MACOSX_BUNDLE_BUNDLE_NAME}.app -f --deep)")
  endif()

which makes the app bundle all good, but then the DMG portion of CPack wipes it out and I have to manually create the image.

If you have any tips from your experience with fixup_bundle, that'd be really helpful - thanks!

[AJenbo]

Good to know, will try and look into it. 1.2.1 is coming out in just a bit over an hour.

[kklobe]

Here's a fresh arm64 build of 1.2.1, built from the release source archive.

devilutionx-1.2.1-mac-arm64.dmg.zip

[Andytizer]

Thank you this build works great. I would really appreciate the arm64 builds being incorporated into the general releases as most M1 Mac users would prefer a native ARM version, especially of the latest 1.3.0 release and future releases too.

[AJenbo]

The issue is that doing so would require a up to date Mac and the one I have access to is from 2011.

[Bozone-Layer]

I greatly appreciate the you’ve done on it. Thank you for the reply.

…

On Dec 10, 2021, at 11:27, Anders Jenbo ***@***.***> wrote:  The issue is that doing so would require a up to date Mac and the one I have access to is from 2011. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[mihauco]

Hello everyone,

it's been a while, Diablo IV was released couple of days ago and, I got a bit nostalgic and realised I've never played first Diablo game. So... if like me you're looking for some newer build of devilutionx for Mac with Apple Silicon, here it is:

devilutionx-1.5.0-mac-arm64.dmg.zip (1.5.0-beta)

It's based on main branch (so it's 1.5.0 if I'm not mistaken), build on MacOS 13.3.1 with M2 Pro. I played it for couple of minutes before posting this message. Tried to build v1.4.1 but got some error from fmt during process (error: static_assert failed due to requirement 'formattable' "Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt"). The newest version builds and works fine for me.

Hope I'll fine more time to actually play it 🙂

Have a good one!

[ephphatha]

https://github.com/orgs/Homebrew/discussions/2843 oh, looks like cross-compiling needs to avoid using brew unless we want to get really complicated with mac build scripts...

[AJenbo]

Probably doable, but does not feel exciting to have to swap out and get it working, but since we are able to do it for iOS probably most of the bits are already there.

[mihauco]

thanks @ephphatha, now I realised that couple of lines before that error there were warnings about ignoring some files:

ld: warning: ignoring file /opt/homebrew/lib/libSDL2main.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/Cellar/sdl2_image/2.6.3_1/lib/libSDL2_image.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/Cellar/libsodium/1.0.18_1/lib/libsodium.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/lib/libfmt.10.0.0.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/lib/libSDL2.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/lib/libSDL2main.a, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/Cellar/sdl2_image/2.6.3_1/lib/libSDL2_image.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/Cellar/libsodium/1.0.18_1/lib/libsodium.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/lib/libfmt.10.0.0.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
ld: warning: ignoring file /opt/homebrew/lib/libSDL2.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64

well, I can try to install homebrew for intel next to my "regular" homebrew version (like described here), and with that I can build separately x86_64 and arm64 versions, but I have no clue if I can somehow combine them later into one package, or if it's possible to tell compiler it should take packages from other directory when working on x84_64 part.

[AJenbo]

@mihauco what did you do in terms of Discord integration, just not enable it?

[mihauco]

didn't enable it

[curby]

Hey folks, given that macOS is moving towards an ARM-only future, is there any hope of having a native ARM version for macOS released by the devilutionX project? I'm impressed by the large number of platforms with "official" devilutionX native binaries, and would love to see ARM macOS be supported in the same way.

By the way, I posted here because this seemed like the most recent, active, and relevant discussion about this sort of thing but I can move it elsewhere if that would be preferable. Thanks!

[AJenbo]

It's easy to do so but as things are right now it would kill support for all Intel based Mac and doing so comes with practically no benefits.

• DevilultionX runs perfectly well via Rosetta2
• Apple is showing no indication of plans to dropping Rosetta2
• The available tools for making universal binaries are non trivial
• None of the active developers have a modern Mac

Rest assured that if tomorrow Apple decides to drop support for Intel applications we will release an ARM-only build same day, but until then we will continue hoping that someone that is a Mac native developer is willing to contribute the time to resolve the technical issues with making universal binaries.

[Trihedraf]

If you build it yourself following the build instructions it will output an Apple Silicon version instead of intel.

[curby]

it would kill support for all Intel based Mac

To be clear, i just meant an additional version, not necessarily a Universal binary and definitely not a replacement for the current x86 binary.

Rest assured that if tomorrow Apple decides to drop support for Intel applications we will release an ARM-only build same day

That's a great relief. I understand that developer resources (and testing hardware) are limited and it's great to know that you'll shift as needed. I appreciate all the work you do. I've been loving DevilutionX so far!

[AJenbo]

I don't see a benefit to having a separate applikation for ARM it just feels like extra work that could result in confusion for Intel users.

I would normally point out https://macsourceports.com/sourceport/devilutionx but unfortunately the have not had the time to build 1.5.0 yet. They mostly do the build manually and it's not compatible with older macOS versions.

[karbes]

I have M1 and just downloaded the source and ran commands for building arm binary, it succeeds. I don't see any reason why both Intel and ARM binaries can't be put up. If you own M1/M2 you don't want Intel binaries. Not reasonable to expect all the users to install brew + compile from the source.

[AJenbo]

I don't see any reason why both Intel and ARM binaries can't be put up.

Ok, buy me a new ARM Mac book and it won't be an issue to do so.

The Intel version works perfectly fine on ARM, so no it is not required for everyone to install brew and compile.

[karbes]

That's the point of GitHub, community helps. Apple Silicon users can build binaries and upload.

[AJenbo]

I can't verify the content of such a build so I won't upload it as an official release.

The goal is to get universal builds working but Apple has made this painfully hard to do. As long as there are no actual issues with using Intel builds on Arm we are not going to reach for workarounds.

[karbes]

Built from the master
devilutionX-1.6.0-dev-macOS-arm64.dmg.zip

[karbes]

Fixed

[Agnapot]

When I try to run this it says the file is "Damaged" with no other information. Not sure whats wrong! I'm on an M2 Air with 14.4.1

[TonioGela]

I can confirm it says it's damaged

[tsal]

Needs to be signed with an ad-hoc key at the very least or people will not be able to run this without disabling kernel-level security (which is generally a bad idea..)

[AJenbo]

The 1.5.3 release is a Universal build so is native on apple hardware and should also be signed with a key.

[vvaassiihhaa]

Thank you ! I have built my own apple app

Install brew - go to https://brew.sh

Open Terminal

git clone https://github.com/diasurgical/devilutionX.git   

cd devilutionX   

brew bundle install

cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=Release -DPNG_ARM_NEON=on
cmake --build build -j $(sysctl -n hw.physicalcpu)

copy file DIABDAT.MPQ in folder build

That's it !

Video ( the old one ) https://youtu.be/xoXMroHGmbM?si=Fk25stkP6eqIZ1w_

(link removed)

[vvaassiihhaa]

yes, it is DevilutionX v1.6.0-dev-Release-322c627f5

and it's work perfect ! :)

apple M2

you can see my first try to play here https://www.twitch.tv/videos/2054116538

[Agnapot]

When trying to build this I get the following cmake error when trying to find libsodium.

CMake Error at /opt/homebrew/Cellar/cmake/3.29.2/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find sodium (missing: sodium_LIBRARY_RELEASE
sodium_LIBRARY_DEBUG) (found version "1.0.19")

Not sure why, I seem to have libsodium installed, but I'm not sure how to check what versions I have, or why it might not be finding it. Any assistance is appreciated!

[StephenCWills]

I don't know much about brew, but the libraries would probably be somewhere under /opt/homebriew/Cellar with the .so extension. You might be able to work around the issue by adding -DDEVILUTIONX_SYSTEM_LIBSODIUM=OFF to the first cmake command.

[Agnapot]

That worked! Thank you! Not sure what the catch was, but it found some version of libsodium that seemed suitable. This is what the cmake said this time:
-- 📚 libsodium: dynamic library from source
It hung there a bit, then moved on, so, success!

[AJenbo]

When you turn off using the system installed package it will download the dependency from source and build it, which is why it hung for a bit.