Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support #199

Open
candicerimba opened this issue Nov 4, 2024 · 2 comments
Open

RTL support #199

candicerimba opened this issue Nov 4, 2024 · 2 comments

Comments

@candicerimba
Copy link

Note: this has to be highly valuable to all users to be considered. Our team has limited time to work on anything that isn't an accessibility feature. That means that we don't have lots of time to review other people's PRs either. So please consider that before requesting the feature.

Describe the solution you'd like
This package doesn't seem to work with RTL. They keyboard navigation stays LTR, and I don't see any way to do RTL just based on its props. As the keyboard navigation isn't a visual function, it's hard to patch it through CSS or anything. I'd ideally like to be able to provide either a dir or any kind of prop to be able to reverse the left key and right key navigation.

What value does this proposed solution bring to users?
More accessible usage to support customers who use RTL languages.

Describe alternatives you've considered

  • A solution outside of the package seems unlikely. This isn't a visual change, but rather a keyboard tracking change.

Additional context
I can consider writing the feature myself, but will need guidance from the team on various things.

Copy link

stale bot commented Jan 3, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 3, 2025
@dgreene1
Copy link
Owner

dgreene1 commented Jan 3, 2025

Our team doesn’t have any internationalization knowledge. It’s not that this feature isn’t valuable, it’s that it’s not something we can help with or review. So it’s a danger to us if we accept a PR for something that we do not understand, because then we would have to support it and any future bugs that come from it. So if you are willing to submit a PR for this, are you willing to submit any related fix that is associated with it?

@stale stale bot removed the wontfix This will not be worked on label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants