Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to Support Spaces in Paths #4000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EthanDieterich
Copy link

Overview

In this branch, I fixed issues my team and I encountered with the Makefile, where it would not function correctly when spaces were present in the path. The issue was traced back to how PATH and SHELL were being set, leading to failures when running make in directories with spaces in their names.

What this PR does / why we need it

  • This PR ensures that paths are properly quoted in the Makefile to prevent issues caused by spaces in directory names.
  • Updates how SHELL passes the PATH variable to ensure compatibility with /bin/sh while keeping the correct environment settings.
  • This fix is necessary for users working in directories with spaces (e.g., /home/user/My Project/), where make previously failed due to improper path handling.

Special notes for your reviewer

@EthanDieterich EthanDieterich marked this pull request as ready for review February 20, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant