chore: fix function name #3562
Closed
chore: fix function name #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: finaltrip <[email protected]>
|
This code is autogenerated I'm afraid. |
|
that is wrong in the template from https://github.com/ent/ent (https://github.com/ent/ent/blob/092b62a3229476d18d9ffade87da268d9136f13a/entc/gen/template/dialect/sql/by.tmpl#L19) we should fix there |
|
PR that fix in upstream: ent/ent#4083 |
Thanks! |
|
fixed, maybe we can rebase? |
Updated. Please review again. |
|
There are no changes in this PR anymore. Do we still need these two commits to be merged? |
|
yep we can close it |
|
Thanks @cpanato |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix function name
What this PR does / why we need it
Special notes for your reviewer