Complain if the env set in SecretEnv cannot be found

Signed-off-by: Sandro <[email protected]>
dexidp · Dec 9, 2023 · f25f720 · f25f720
1 parent e41a28b
commit f25f720
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/cmd/dex/serve.go b/cmd/dex/serve.go
@@ -197,7 +197,11 @@ func runServe(options serveOptions) error {
 				if client.Secret != "" {
 					return fmt.Errorf("invalid config: Secret and SecretEnv fields are exclusive for client %q", client.ID)
 				}
-				c.StaticClients[i].Secret = os.Getenv(client.SecretEnv)
+				secret := os.Getenv(client.SecretEnv)
+				if secret == "" {
+					return fmt.Errorf("invalid config: could not find SecretEnv %q", client.SecretEnv)
+				}
+				c.StaticClients[i].Secret = secret
 			}
 			logger.Infof("config static client: %s", client.Name)
 		}