Skip to content

Commit

Permalink
update cf connector to use slog instead
Browse files Browse the repository at this point in the history
Signed-off-by: Taylor Silva <[email protected]>
  • Loading branch information
taylorsilva authored and CI Bot committed Feb 19, 2025
1 parent 28686a7 commit 363fecb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
21 changes: 8 additions & 13 deletions connector/cloudfoundry/cloudfoundry.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"encoding/json"
"errors"
"fmt"
"log/slog"
"net"
"net/http"
"os"
Expand All @@ -17,7 +18,6 @@ import (
"golang.org/x/oauth2"

"github.com/dexidp/dex/connector"
"github.com/dexidp/dex/pkg/log"
)

type cloudfoundryConnector struct {
Expand All @@ -29,7 +29,7 @@ type cloudfoundryConnector struct {
authorizationURL string
userInfoURL string
httpClient *http.Client
logger log.Logger
logger *slog.Logger
}

type connectorData struct {
Expand Down Expand Up @@ -106,7 +106,7 @@ type login struct {
Href string `json:"href"`
}

func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error) {
func (c *Config) Open(id string, logger *slog.Logger) (connector.Connector, error) {
var err error

cloudfoundryConn := &cloudfoundryConnector{
Expand All @@ -125,16 +125,14 @@ func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error)
apiURL := strings.TrimRight(c.APIURL, "/")
apiResp, err := cloudfoundryConn.httpClient.Get(apiURL)
if err != nil {
logger.Errorf("failed-to-send-request-to-cloud-controller-api", err)
return nil, err
return nil, fmt.Errorf("failed-to-send-request-to-cloud-controller-api: %w", err)
}

defer apiResp.Body.Close()

if apiResp.StatusCode != http.StatusOK {
err = fmt.Errorf("request failed with status %d", apiResp.StatusCode)
logger.Errorf("failed-get-info-response-from-api", err)
return nil, err
return nil, fmt.Errorf("failed-get-info-response-from-api: %w", err)
}

var apiResult infoResp
Expand All @@ -144,14 +142,12 @@ func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error)
uaaURL := strings.TrimRight(apiResult.Links.Login.Href, "/")
uaaResp, err := cloudfoundryConn.httpClient.Get(fmt.Sprintf("%s/.well-known/openid-configuration", uaaURL))
if err != nil {
logger.Errorf("failed-to-send-request-to-uaa-api", err)
return nil, err
return nil, fmt.Errorf("failed-to-send-request-to-uaa-api: %w", err)
}

if apiResp.StatusCode != http.StatusOK {
err = fmt.Errorf("request failed with status %d", apiResp.StatusCode)
logger.Errorf("failed-to-get-well-known-config-response-from-api", err)
return nil, err
return nil, fmt.Errorf("failed-to-get-well-known-config-response-from-api: %w", err)
}

defer uaaResp.Body.Close()
Expand All @@ -160,8 +156,7 @@ func (c *Config) Open(id string, logger log.Logger) (connector.Connector, error)
err = json.NewDecoder(uaaResp.Body).Decode(&uaaResult)

Check failure on line 157 in connector/cloudfoundry/cloudfoundry.go

View workflow job for this annotation

GitHub Actions / Lint

File is not properly formatted (gofumpt)
if err != nil {
logger.Errorf("failed-to-decode-response-from-uaa-api", err)
return nil, err
return nil, fmt.Errorf("failed-to-decode-response-from-uaa-api: %w", err)
}

cloudfoundryConn.tokenURL, _ = uaaResult["token_endpoint"].(string)
Expand Down
6 changes: 3 additions & 3 deletions connector/cloudfoundry/cloudfoundry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ import (
"encoding/json"
"errors"
"fmt"
"io"
"log/slog"
"net/http"
"net/http/httptest"
"reflect"
"strings"
"testing"

"github.com/sirupsen/logrus"

"github.com/dexidp/dex/connector"
)

Expand Down Expand Up @@ -510,7 +510,7 @@ func newConnector(t *testing.T, serverURL string) *cloudfoundryConnector {
InsecureSkipVerify: true,
}

log := logrus.New()
log := slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{}))

conn, err := testConfig.Open("id", log)
if err != nil {
Expand Down

0 comments on commit 363fecb

Please sign in to comment.