Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1110: Fixed ide status fails with IllegalStateException when being offline #1125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

#1110: Fixed ide status fails with IllegalStateException when being offline #1125

wants to merge 4 commits into from
+28 −5

Conversation

paz-capgemini
Copy link
Contributor

Fixes #1110

  • Skip the checkUpdate step when running the status command while being offline and print warning message that this step was skipped

Screenshot 2025-03-11 103526

@paz-capgemini paz-capgemini self-assigned this Mar 11, 2025
@coveralls
Copy link
Collaborator

coveralls commented Mar 11, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13789076997

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 68.633%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/StatusCommandlet.java 16 30.23%
Totals Coverage Status
Change from base Build 13788010324: 0.01%
Covered Lines: 7940
Relevant Lines: 11122
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready for review.

@jan-vcapgemini jan-vcapgemini requested a review from hohwille March 11, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

@hohwille hohwille Awaiting requested review from hohwille

Assignees

@hohwille hohwille

@paz-capgemini paz-capgemini

Labels
None yet
Projects
IDEasy board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ide status fails with IllegalStateException
4 participants
@paz-capgemini @coveralls @jan-vcapgemini @hohwille