Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move url-updater into new module #1024

Open
jan-vcapgemini opened this issue Feb 7, 2025 · 0 comments · May be fixed by #1025
Open

Move url-updater into new module #1024

jan-vcapgemini opened this issue Feb 7, 2025 · 0 comments · May be fixed by #1025
Assignees
@jan-vcapgemini
Labels
enhancement New feature or request

Comments

@jan-vcapgemini
Copy link
Contributor

We need to move the url-updater into a new module as introduced in #1017
@jan-vcapgemini jan-vcapgemini added the enhancement New feature or request label Feb 7, 2025
@jan-vcapgemini jan-vcapgemini self-assigned this Feb 7, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Feb 7, 2025
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to 🏗 In progress in IDEasy board Feb 7, 2025
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Feb 7, 2025
@jan-vcapgemini
devonfw#1024: Move urls into url-updater module
8a12beb 
adjusted github action workflow
updated wiremock from com.github.tomakehurst 2.35.2 to org.wiremock 3.11.0
added jackson-core dependency to ide-cli
added url to url tool test classes package name
@jan-vcapgemini jan-vcapgemini linked a pull request Feb 7, 2025 that will close this issue
Open
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Feb 17, 2025
@jan-vcapgemini
devonfw#1024: added tests of WindowsHelperImpl
31d8719
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Feb 17, 2025
@jan-vcapgemini
devonfw#1024: added extract test to FileAccess tests
a13df27
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Feb 20, 2025
@jan-vcapgemini
devonfw#1024: added AwsGithubUrlUpdaterTest
fa51e42 
added test and resources
added getter of baseUrl to AwsUrlUpdater to be able to mock it
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Feb 20, 2025
@jan-vcapgemini
devonfw#1024: added comments
502ab58
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Feb 20, 2025
@jan-vcapgemini
devonfw#1024: fixed remote url
42f8fce
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
768f13f 
introduced maven dependencyManagement
removed unnecessary properties from url-updater module
moved dependency version variables to root pom.xml
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
f7c08e3 
moved getBaseUrl method to GithubUrlUpdater
added Override to sub classes using getBaseUrl
used getBasedUrl in each GithubUrlUpdater to construct download urls
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
c8f81c5 
moved url specific classes from cli module to url-updater module
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
5ff2362 
replaced import with fully qualified reference
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
b003ef9 
moved url specific classes from cli module to url-updater module
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
ba7b08b 
adjusted github workflow
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
518f7c2 
removed unnecessary method
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: implemented requested changes
c43f9c5 
replaced import with fully qualified reference
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: fixed pom.xml
b49c1c0
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: adjusted java version
925bcd1 
changed java version from 17 to 21
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: fixed pom.xml
8dbd60f
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: fixed pom.xml
702af2d
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: changed java version in github actions from 17 to 21
249dc19
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: fixed gui pom.xml
bc0f747
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 5, 2025
@jan-vcapgemini
devonfw#1024: fixed url-updater pom.xml
3e7a1dd
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 6, 2025
@jan-vcapgemini
devonfw#1024: implemented requested change
83484bc 
removed jackson-core dependency from cli
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 6, 2025
@jan-vcapgemini
devonfw#1024: implemented requested change
99c1b9d 
removed jackson-core dependency from root pom
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Mar 6, 2025
@jan-vcapgemini
devonfw#1024: adjusted base urls
5dc5414 
removed / from aws base url
replaced graalvm base url with GITHUB_BASE_URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-vcapgemini jan-vcapgemini

Labels
enhancement New feature or request
Projects
IDEasy board
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1024: Move urls into url-updater module jan-vcapgemini/IDEasy
1 participant
@jan-vcapgemini