compiler: regain correctness for indirections

Author: georgebisbas

devito/ir/clusters/cluster.py

@@ -367,7 +367,12 @@ def dspace(self):
         for f, v in parts.items():
             for i in v:
                 if i.dim in oobs:
-                    intervals = intervals.ceil(v[i.dim])
+                    try:
+                        if intervals[i.dim].upper > v[i.dim].upper and \
+                           bool(i.dim in f.dimensions):
+                            intervals = intervals.ceil(v[i.dim])
+                    except AttributeError:
+                        pass
 
         return DataSpace(intervals, parts)
 

devito/ir/support/utils.py

@@ -127,7 +127,6 @@ def detect_accesses(exprs):
     mapper = defaultdict(Stencil)
     for e in retrieve_indexed(exprs, deep=True):
         f = e.function
-
         for a, d0 in zip(e.indices, f.dimensions):
             if isinstance(a, Indirection):
                 a = a.mapped

devito/types/dimension.py

@@ -342,7 +342,7 @@ def _arg_check(self, args, size, interval):
                 # Autopadding causes non-integer upper limit
                 from devito.symbolics import normalize_args
                 upper = interval.upper.subs(normalize_args(args))
-            if args[self.max_name] + upper > size:
+            if args[self.max_name] + upper >= size:
                 raise InvalidArgument("OOB detected due to %s=%d" % (self.max_name,
                                                                      args[self.max_name]))
 

examples/userapi/02_apply.ipynb

@@ -250,14 +250,14 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "OOB detected due to time_M=3\n"
+      "OOB detected due to time_M=2\n"
      ]
     }
    ],
    "source": [
     "from devito.exceptions import InvalidArgument\n",
     "try:\n",
-    "    op.apply(time_M=3)\n",
+    "    op.apply(time_M=2)\n",
     "except InvalidArgument as e:\n",
     "    print(e)"
    ]