Skip to content

Commit f858c8e

Browse files
authored
Merge pull request #118 from yangcao77/626-adopt-outerLoop
update library for image component type
2 parents b7c2cb5 + 197718d commit f858c8e

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

pkg/devfile/parser/data/v2/common/component_helper.go

+2
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ func GetComponentType(component v1.Component) (v1.ComponentType, error) {
2929
return v1.KubernetesComponentType, nil
3030
case component.Openshift != nil:
3131
return v1.OpenshiftComponentType, nil
32+
case component.Image != nil:
33+
return v1.ImageComponentType, nil
3234
case component.Custom != nil:
3335
return v1.CustomComponentType, nil
3436

pkg/devfile/parser/data/v2/common/component_helper_test.go

+10
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,16 @@ func TestGetComponentType(t *testing.T) {
150150
},
151151
componentType: v1.PluginComponentType,
152152
},
153+
{
154+
name: "Image component",
155+
component: v1.Component{
156+
Name: "name",
157+
ComponentUnion: v1.ComponentUnion{
158+
Image: &v1.ImageComponent{},
159+
},
160+
},
161+
componentType: v1.ImageComponentType,
162+
},
153163
{
154164
name: "Custom component",
155165
component: v1.Component{

pkg/devfile/parser/devfileobj.go

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77

88
// Default filenames for create devfile
99
const (
10-
OutputDevfileJsonPath = "devfile.json"
1110
OutputDevfileYamlPath = "devfile.yaml"
1211
)
1312

0 commit comments

Comments
 (0)