Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is not enabled when deno.lock is present #1219

Closed
bartlomieju opened this issue Dec 3, 2024 · 1 comment
Closed

Extension is not enabled when deno.lock is present #1219

bartlomieju opened this issue Dec 3, 2024 · 1 comment

Comments

@bartlomieju
Copy link
Member

Describe the bug

Currently the extension enables itself only if deno.json is present, but doesn't enable itself if only deno.lock is present. This means that projects that are using Deno as a package manager but keep all dependencies in package.json don't enable the extension automatically. Instead it needs to be enabled manually via command pallete.

To Reproduce

  1. Take existing Node.js project
  2. Run deno install
  3. Deno extension is not enabled

Expected behavior

Extension gets enabled if there's deno.lock file.

Versions

deno: 2.1.2

@nayeemrmn nayeemrmn removed their assignment Mar 4, 2025
@nayeemrmn
Copy link
Collaborator

Discussed in meeting. The team agreed we shouldn't do this. Running a deno command or using it for dep management doesn't mean you want the LSP enabled, and users would be very confused in this case.

@nayeemrmn nayeemrmn closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants