Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation calls deno add an alias for deno install, and deno remove alias for deno uninstall #975

Closed
matthewjnield opened this issue Oct 10, 2024 · 2 comments · May be fixed by #1016
Closed

Comments

@matthewjnield
Copy link

The documentation page for the CLI runtime subcommand deno install (https://docs.deno.com/runtime/reference/cli/install/) says that the subcommand deno add is an alias for deno install.

I think that calling this an alias is misleading since the two commands do not do the same thing. deno add only updates the configuration file to add the specified dependency to the "imports" field. deno install actually downloads and installs dependencies on the user's computer.

image

Similarly, the documentation page for the CLI runtime subcommand deno uninstall (https://docs.deno.com/runtime/reference/cli/uninstall/) says that the subcommand deno remove is an alias for deno uninstall.

I think that calling this an alias is misleading since the two commands do not do the same thing. deno remove only updates the configuration file to remove the specified dependency from the "imports" field. deno install actually removes/uninstalls dependencies form the user's computer.

image

@thisisjofrank
Copy link
Collaborator

The tip is now deleted

@matthewjnield
Copy link
Author

@thisisjofrank Thank you for looking at this issue. The tips appear to still be in the files for both pages (screenshots and line numbers shown below). If you agree with the suggestion to remove or modify these to be less misleading about what the subcommands do, I will gladly open a pull request with suggested changes.

runtime/reference/cli/install.md, lines 31 to 35

image

runtime/reference/cli/uninstall.md, lines 33 to 37

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants