Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import string replaces numbers with underscores #803

Open
c43721 opened this issue Oct 31, 2024 · 1 comment · May be fixed by denoland/deno_doc#655
Open

Import string replaces numbers with underscores #803

c43721 opened this issue Oct 31, 2024 · 1 comment · May be fixed by denoland/deno_doc#655
Labels
bug Something isn't working docs gen Related to the documentation generation

Comments

@c43721
Copy link

c43721 commented Oct 31, 2024

I assume this is an overly ambitious code block that's trying to replace invalid characters with underscores but it shouldn't do that with numbers since _c43721_rcon is a valid import name in JS (at least that's what my editor is suggesting.)

I'd expect this to be import * as _c43721_rcon from "jsr:@c43721/rcon";

image

Example: https://jsr.io/@c43721/rcon
@c43721 c43721 mentioned this issue Oct 31, 2024
Closed
@crowlKats crowlKats added bug Something isn't working docs gen Related to the documentation generation labels Oct 31, 2024
@c43721
Copy link
Author

c43721 commented Nov 2, 2024

Seems like it works fine when you're on a specific type
image

Example: https://jsr.io/@c43721/rcon/doc/~/RconOptions

This was referenced Nov 7, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working docs gen Related to the documentation generation
Projects
JSR
Status: Needs Triage
Milestone
No milestone
2 participants
@crowlKats @c43721