fix: aarch64 ssl handshakes #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
rtyler,
fvaleye and
roeap
as code owners
ion-elgreco
force-pushed
the
fix/aarch64-ssl-handshakes
branch
from
99e2c83 to
eb24556
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
- Coverage 72.10% 72.09% -0.01%
==========================================
Files 143 143
Lines 45704 45704
Branches 45704 45704
==========================================
- Hits 32954 32950 -4
+ Misses 10669 10668 -1
- Partials 2081 2086 +5 ☔ View full report in Codecov by Sentry. |
ion-elgreco
force-pushed
the
fix/aarch64-ssl-handshakes
branch
from
eb24556 to
d86e15d
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
fix/aarch64-ssl-handshakes
branch
from
d86e15d to
3bdea72
Compare
rtyler
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a very pesky issue to figure out but finally nailed it down to being a manylinux glibc compatibility issue. Essentially with glibc 2.17 we were seeing ssl handshake failures which has some relation to the ring crate. Anyway, the fix is to release additional wheels for manylinux 2_28.
I also took the liberty in splitting up the manylinux job in to separate jobs.
Related Issue(s)
is_deltatablethrowing S3 error in 0.25.1 on linux aarch64 build #3241